Make target for building wheel #1031
Conversation
|
Thanks @smaragden for helping us on this! I just left a small comment regarding the command used to build the wheel. |
|
Oh, and if you want GitHub to automatically link the issue to this PR, you need to remove the back ticks around "Fixes #1005" in the PR description. |
|
When merging, please squash the commits and use the Summary from the PR as message. |
Replacing wheel build command from: `python setup.py bdist_wheel` with: `pip wheel . --no-deps` This will have several advantages. Use pyproject for dependencies. This makes it much cleaner to build wheels. We no longer need to check for the availability of the wheel package. And the build will be out of source, and we don't need to cleanup intermediate folders. The `clean` target will now remove *.whl files in the root of the project. This is where `make wheel` will output the wheels to with the new command.
Codecov Report
@@ Coverage Diff @@
## master #1031 +/- ##
=======================================
Coverage 79.30% 79.30%
=======================================
Files 113 113
Lines 6102 6102
=======================================
Hits 4839 4839
Misses 1263 1263
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
|
Thank you @smaragden! |
Fixes #1005
Summary
Adds a
wheeltarget to the Makefile.Running
make wheelwill build a.whlpackage for the available python version to the root of the project.Running
make cleanwill remove all*.whlfiles from the project root.