Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use const references when catching exceptions #1034

Merged

Conversation

darbyjohnston
Copy link
Contributor

@darbyjohnston darbyjohnston commented Aug 6, 2021

Fixes #1033

This PR fixes a couple warnings from gcc 10.3:

warning: catching polymorphic type ‘class std::exception’ by value [-Wcatch-value=]

@codecov-commenter
Copy link

Codecov Report

Merging #1034 (bd7f66e) into master (a84265c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1034   +/-   ##
=======================================
  Coverage   79.30%   79.30%           
=======================================
  Files         113      113           
  Lines        6102     6102           
=======================================
  Hits         4839     4839           
  Misses       1263     1263           
Flag Coverage Δ
unittests 79.30% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/opentime/rationalTime.cpp 85.32% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a84265c...bd7f66e. Read the comment docs.

@meshula meshula merged commit 3a312c6 into AcademySoftwareFoundation:master Aug 7, 2021
@ssteinbach ssteinbach added this to the Public Beta 14 milestone Oct 26, 2021
@darbyjohnston darbyjohnston deleted the catch_const_ref branch November 27, 2021 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use const references when catching exceptions
4 participants