Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused source file "main.cpp" #1036

Merged

Conversation

darbyjohnston
Copy link
Contributor

@darbyjohnston darbyjohnston commented Aug 6, 2021

Fixes #1035

This PR removes the source file src/operntimelineio/main.cpp which isn't being used.

@codecov-commenter
Copy link

codecov-commenter commented Aug 6, 2021

Codecov Report

Merging #1036 (0bf95d4) into master (a84265c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1036   +/-   ##
=======================================
  Coverage   79.30%   79.30%           
=======================================
  Files         113      113           
  Lines        6102     6102           
=======================================
  Hits         4839     4839           
  Misses       1263     1263           
Flag Coverage Δ
unittests 79.30% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a84265c...0bf95d4. Read the comment docs.

@meshula
Copy link
Collaborator

meshula commented Aug 7, 2021

one of the const exception commits actually snuck in...

Copy link
Collaborator

@meshula meshula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A const exception clean up accidentally snuck in...

@darbyjohnston
Copy link
Contributor Author

Whoops, sorry! That's what I get for not checking the diff...

@meshula meshula merged commit 957651d into AcademySoftwareFoundation:master Aug 7, 2021
@ssteinbach ssteinbach changed the title Remove unused Remove unused source file "main.cpp" Oct 26, 2021
@ssteinbach ssteinbach added this to the Public Beta 14 milestone Oct 26, 2021
@darbyjohnston darbyjohnston deleted the remove_unused branch November 27, 2021 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove unused code in opentimelilneio
4 participants