Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing Python coverage in Codecov reports #1040

Conversation

JeanChristopheMorinPerso
Copy link
Member

@JeanChristopheMorinPerso JeanChristopheMorinPerso commented Aug 7, 2021

Fixes #1039

Use one line for each Issue. This allows auto-closing the related issue when the fix is merged.

Summary

As stated in #1039 , with the recent update of the codecov/codecov-action GH action, the Python coverage is missing from the Codecov reports.

This is due to the fact that the old Codecov action was using a different uploader script that was taking care of calling coverage xml when it found Python coverage files. The new action doesn't seem to do it.

So the fix is as simple as calling coverage xml from the make coverage target.

I've also added an rm in the lcov target because the C++ coverage files coverage.filtered.info and coverage.info were both uploaded which waas basically undoing the filtering we were doing in the lcov target. Though, I see that there is also some filtering in .codecov.yml, but it doesn't seems to be applied... Not too sure why.

@codecov-commenter
Copy link

codecov-commenter commented Aug 7, 2021

Codecov Report

Merging #1040 (f93aab8) into master (aada787) will increase coverage by 3.52%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1040      +/-   ##
==========================================
+ Coverage   82.78%   86.31%   +3.52%     
==========================================
  Files          75      190     +115     
  Lines        3306    18963   +15657     
  Branches        0     2099    +2099     
==========================================
+ Hits         2737    16367   +13630     
- Misses        569     2050    +1481     
- Partials        0      546     +546     
Flag Coverage Δ
unittests 86.31% <ø> (+3.52%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
tests/test_cmx_3600_adapter.py 99.03% <0.00%> (ø)
...-opentimelineio/opentimelineio/plugins/manifest.py 86.56% <0.00%> (ø)
tests/baselines/example_schemadef.py 85.71% <0.00%> (ø)
tests/test_filter_algorithms.py 98.89% <0.00%> (ø)
.../opentimelineio/schema/image_sequence_reference.py 100.00% <0.00%> (ø)
...y-opentimelineio/opentimelineio/schema/timeline.py 100.00% <0.00%> (ø)
tests/test_marker.py 94.28% <0.00%> (ø)
...timelineio/console/autogen_plugin_documentation.py 72.72% <0.00%> (ø)
.../opentimelineio_contrib/adapters/ffmpeg_burnins.py 0.00% <0.00%> (ø)
tests/test_cdl.py 95.00% <0.00%> (ø)
... and 105 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aada787...f93aab8. Read the comment docs.

@JeanChristopheMorinPerso
Copy link
Member Author

JeanChristopheMorinPerso commented Aug 15, 2021

For transparency: I've let this PR as a draft while I find time to investigate a little bit more. I'd like to get to the bottom of why the ignore list in .codecov.yaml doesn't seems to have any effect.

If anyone wants to participate/help, feel free to reply :)

I was also unable to produce C++ coverage on my Linux laptop, which annoys me quite a lot.

@ssteinbach ssteinbach added this to In progress in WG: Build Improvements via automation Sep 30, 2021
@jminor jminor added this to the Public Beta 14 milestone Oct 11, 2021
@JeanChristopheMorinPerso JeanChristopheMorinPerso marked this pull request as ready for review October 12, 2021 01:49
@JeanChristopheMorinPerso
Copy link
Member Author

JeanChristopheMorinPerso commented Oct 12, 2021

This is now ready to be reviewed.

WG: Build Improvements automation moved this from In progress to Reviewer approved Oct 13, 2021
Copy link
Collaborator

@ssteinbach ssteinbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@ssteinbach ssteinbach merged commit 80c7d65 into AcademySoftwareFoundation:master Oct 14, 2021
WG: Build Improvements automation moved this from Reviewer approved to Done Oct 14, 2021
@JeanChristopheMorinPerso JeanChristopheMorinPerso deleted the fix_codecov_reports_python branch October 15, 2021 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

Python coverage is missing from Codecov reports
5 participants