New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix missing Python coverage in Codecov reports #1040
Fix missing Python coverage in Codecov reports #1040
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1040 +/- ##
==========================================
+ Coverage 82.78% 86.31% +3.52%
==========================================
Files 75 190 +115
Lines 3306 18963 +15657
Branches 0 2099 +2099
==========================================
+ Hits 2737 16367 +13630
- Misses 569 2050 +1481
- Partials 0 546 +546
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
For transparency: I've let this PR as a draft while I find time to investigate a little bit more. I'd like to get to the bottom of why the If anyone wants to participate/help, feel free to reply :) I was also unable to produce C++ coverage on my Linux laptop, which annoys me quite a lot. |
5445f6a
to
f93aab8
Compare
This is now ready to be reviewed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks!
Fixes #1039
Use one line for each Issue. This allows auto-closing the related issue when the fix is merged.
Summary
As stated in #1039 , with the recent update of the
codecov/codecov-action
GH action, the Python coverage is missing from the Codecov reports.This is due to the fact that the old Codecov action was using a different uploader script that was taking care of calling
coverage xml
when it found Python coverage files. The new action doesn't seem to do it.So the fix is as simple as calling
coverage xml
from themake coverage
target.I've also added an
rm
in thelcov
target because the C++ coverage filescoverage.filtered.info
andcoverage.info
were both uploaded which waas basically undoing the filtering we were doing in thelcov
target. Though, I see that there is also some filtering in.codecov.yml
, but it doesn't seems to be applied... Not too sure why.