Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove vestigal python install code from CMake build system #1113

Conversation

ssteinbach
Copy link
Collaborator

  • In the current build system, a correct python installation requires using setup.py, either through pip install or python setup.py install.
  • there was code that was always attempting to install python headers, even in C++ only builds
  • ...and python building was on by default, even though it was incorrect when only building through cmake.

- setup.py handles the python install now, so this code is no longer
  needed in cmake
- Also, do not _always_ install python headers on build.
- A correct python build requires using setup.py, either through pip or
  python setup.py install.
@ssteinbach ssteinbach added this to the Public Beta 14 milestone Oct 21, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #1113 (3f7c583) into master (0cc00ce) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1113   +/-   ##
=======================================
  Coverage   86.20%   86.20%           
=======================================
  Files         191      191           
  Lines       19028    19028           
  Branches     2105     2105           
=======================================
  Hits        16404    16404           
  Misses       2078     2078           
  Partials      546      546           
Flag Coverage Δ
unittests 86.20% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0cc00ce...3f7c583. Read the comment docs.

@ssteinbach ssteinbach merged commit 21f9f06 into AcademySoftwareFoundation:master Oct 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants