Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate error code NON_DROPFRAME_RATE. #1114

Conversation

ssteinbach
Copy link
Collaborator

Closes #625

RationalTime had a duplicate error code in it that was only used in one
place.

RationalTime had a duplicate error code in it that was only used in one
place.
@ssteinbach ssteinbach added this to the Public Beta 14 milestone Oct 22, 2021
@ssteinbach ssteinbach added this to To Do in C++ API via automation Oct 22, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #1114 (4201d6b) into master (1dbe0fc) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1114   +/-   ##
=======================================
  Coverage   86.21%   86.21%           
=======================================
  Files         191      191           
  Lines       19030    19029    -1     
  Branches     2105     2105           
=======================================
  Hits        16406    16406           
+ Misses       2078     2077    -1     
  Partials      546      546           
Flag Coverage Δ
unittests 86.21% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/opentime/errorStatus.cpp 55.55% <ø> (+5.55%) ⬆️
src/opentime/errorStatus.h 100.00% <ø> (ø)
tests/test_opentime.py 99.72% <ø> (ø)
src/opentime/rationalTime.cpp 82.75% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1dbe0fc...4201d6b. Read the comment docs.

@meshula meshula merged commit f5fea70 into AcademySoftwareFoundation:master Oct 22, 2021
C++ API automation moved this from To Do to Done Oct 22, 2021
@ssteinbach ssteinbach deleted the i625.remove_duplicate_error_code branch October 22, 2021 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
C++ API
  
Done
Development

Successfully merging this pull request may close these issues.

OpenTime has redundant timecode errors
3 participants