-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
from_start_end_time_inclusive #868
from_start_end_time_inclusive #868
Conversation
…_time_inclusive to RationalTime and TimeRange respectively.
Codecov Report
@@ Coverage Diff @@
## master #868 +/- ##
==========================================
+ Coverage 84.18% 84.27% +0.08%
==========================================
Files 74 74
Lines 3061 3084 +23
==========================================
+ Hits 2577 2599 +22
- Misses 484 485 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me. Thanks for adding tests!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really small note to get over the lint failure (to see the lint results locally, run make lint
from the top of the source directory)).
Thanks!
duration_from_start_end_time = RationalTime.duration_from_start_end_time | ||
duration_from_start_end_time_inclusive = RationalTime.duration_from_start_end_time_inclusive |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is triggering a lint error for being too long (see: https://github.com/PixarAnimationStudios/OpenTimelineIO/pull/868/checks?check_run_id=1714226672 ). I think you can fix it:
duration_from_start_end_time_inclusive = RationalTime.duration_from_start_end_time_inclusive | |
duration_from_start_end_time_inclusive = ( | |
RationalTime.duration_from_start_end_time_inclusive | |
) |
Great, thanks! |
@splidje I don't see a CLA from you. Did I miss it? If not, could you send us a signed CLA as documented here: https://opentimelineio.readthedocs.io/en/latest/tutorials/contributing.html |
Apologies! I've sent that over now. |
Thanks! Got it. |
Added duration_from_start_end_time_inclusive and range_from_start_end_time_inclusive to RationalTime and TimeRange respectively.