-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
C++ binding Docstring Update #983
C++ binding Docstring Update #983
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I have a few small suggestions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thank you for the contribution!
Codecov Report
@@ Coverage Diff @@
## master #983 +/- ##
==========================================
- Coverage 85.63% 85.62% -0.02%
==========================================
Files 191 191
Lines 18231 18235 +4
Branches 2074 2074
==========================================
+ Hits 15613 15614 +1
- Misses 2087 2090 +3
Partials 531 531
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Link the Issue(s) this Pull Request is related to.
Fixes #704
Summarize your change.
Reason:
For the users to have readily available docstrings in the C++ binding of methods & functions from python implementation.
Changes in files:
Reference associated tests.