Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C++ binding Docstring Update #983

Merged

Conversation

Viraj-Rana008
Copy link
Contributor

Link the Issue(s) this Pull Request is related to.

Fixes #704

Summarize your change.

Reason:
For the users to have readily available docstrings in the C++ binding of methods & functions from python implementation.

Changes in files:

  • src/py-opentimelineio/opentime-bindings/opentime_rationalTime.cpp
  • src/py-opentimelineio/opentime-bindings/opentime_timeRange.cpp

Reference associated tests.

Copy link
Collaborator

@meshula meshula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I have a few small suggestions.

Copy link
Collaborator

@meshula meshula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you for the contribution!

@codecov-commenter
Copy link

Codecov Report

Merging #983 (4706744) into master (bd56474) will decrease coverage by 0.01%.
The diff coverage is 76.92%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #983      +/-   ##
==========================================
- Coverage   85.63%   85.62%   -0.02%     
==========================================
  Files         191      191              
  Lines       18231    18235       +4     
  Branches     2074     2074              
==========================================
+ Hits        15613    15614       +1     
- Misses       2087     2090       +3     
  Partials      531      531              
Flag Coverage Δ
unittests 85.62% <76.92%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ineio/opentime-bindings/opentime_timeTransform.cpp 90.00% <ø> (ø)
...imelineio/opentime-bindings/opentime_timeRange.cpp 95.08% <66.66%> (-4.92%) ⬇️
...lineio/opentime-bindings/opentime_rationalTime.cpp 95.89% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd56474...4706744. Read the comment docs.

@meshula meshula merged commit a3caa7d into AcademySoftwareFoundation:master Jun 14, 2021
@ssteinbach ssteinbach added this to the Public Beta 14 milestone Jun 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants