Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

APPLE: Add usdView controls to show/hide the sky dome #2123

Closed
wants to merge 0 commits into from
Closed

APPLE: Add usdView controls to show/hide the sky dome #2123

wants to merge 0 commits into from

Conversation

creijon
Copy link
Contributor

@creijon creijon commented Dec 4, 2022 •
edited
Loading

Description of Change(s)

With 22.11 there was the new domeLightCameraVisibility render setting to hide the sky dome background when the dome light was enabled. This is really useful for displaying quality lighting in the viewport while maintaining a transparent or flat background.

This change hooks up the setting to a new menu item in usdView, under Display -> Show Dome Light Textures

Fixes Issue(s)

  • Control of skydome rendering in usdView
  • I have verified that all unit tests pass with the proposed changes
  • I have submitted a signed Contributor License Agreement

@creijon creijon changed the title APPLE: Add usdView controls to show/hide the skydive APPLE: Add usdView controls to show/hide the skydome Dec 4, 2022
@creijon creijon changed the title APPLE: Add usdView controls to show/hide the skydome APPLE: Add usdView controls to show/hide the sky dome Dec 4, 2022
@sunyab
Copy link
Contributor

sunyab commented Dec 9, 2022

Filed as internal issue #USD-7819

@FlorianZ
Copy link
Contributor

FlorianZ commented Jan 6, 2023

@jonny-apple, we had our UI/UX design team take a look and they recommended moving this option to the "Display" menu and calling it "Show Dome Light Textures" instead. Would you mind updating the PR with that change? Thank you!

@creijon
Copy link
Contributor Author

creijon commented Jan 10, 2023

@jonny-apple, we had our UI/UX design team take a look and they recommended moving this option to the "Display" menu and calling it "Show Dome Light Textures" instead. Would you mind updating the PR with that change? Thank you!

Certainly, I'll do that right away.

@creijon
Copy link
Contributor Author

creijon commented Jan 10, 2023

@jonny-apple, we had our UI/UX design team take a look and they recommended moving this option to the "Display" menu and calling it "Show Dome Light Textures" instead. Would you mind updating the PR with that change? Thank you!

Certainly, I'll do that right away.

Done!

@creijon creijon force-pushed the jon/dev/skydome_background branch 2 times, most recently from d036683 to 2ce933e Compare January 15, 2023 14:25
@creijon
Copy link
Contributor Author

creijon commented Jan 17, 2023

Cleaned up the Python code to use consistent naming.

pixar-oss added a commit that referenced this pull request Jan 27, 2023
@pixar-oss
Merge pull request #2123 from jonny-apple/jon/dev/skydome_background
899d8f9 
APPLE: Add usdView controls to show/hide the sky dome

(Internal change: 2259791)
@creijon creijon closed this Jan 30, 2023
@creijon creijon deleted the jon/dev/skydome_background branch January 30, 2023 08:52
@drwave drwave mentioned this pull request Jul 31, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@creijon @sunyab @FlorianZ