Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI Texture Update #406

Merged
merged 9 commits into from
May 28, 2024
Merged

Conversation

careeoki
Copy link
Contributor

@careeoki careeoki commented May 26, 2024

Updates UI textures to match the newest block textures. Also improves the legibility of icons.
Fixes #373 and fixes #361
image
image
Note that the hotbar is now opaque. I think it being translucent was nice, but to do that we need another texture/some code

@archbirdplus
Copy link
Contributor

My thoughts

  • looks a little too cartoonish for my taste
  • scroll bar is really thin
  • the checkboxes are amazing!
  • +/- zoom icon is more intuitive
  • red cross icon looks out of place in thickness and it's also somewhat out of bounds
Screenshot 2024-05-26 at 10 44 23

@careeoki
Copy link
Contributor Author

I can't change the scrollbar because it is made in code, which is not my department. Same with the icon spacing/window title height.
Here's a different X:
image

@archbirdplus
Copy link
Contributor

This X looks a little more natural.
The inventory slider width is defined here if you want to try: https://github.com/PixelGuys/Cubyz/blob/master/src/gui/components/VerticalList.zig#L16C24-L16C25

@careeoki
Copy link
Contributor Author

image

@du82
Copy link

du82 commented May 27, 2024

so much better!

@archbirdplus
Copy link
Contributor

Lol, you replaced all the tabs with spaces trying to edit that one line.

@careeoki
Copy link
Contributor Author

I warned you!
The value 10 looked good. Someone else can do it for me in 30 seconds.

@tillpp
Copy link
Contributor

tillpp commented May 27, 2024

Personally, i would say, the bigger red cross, looked better, but anyway:

could you make the inside of the red cross, a bit brighter for more contrast?
Compared to the zoom buttons,the cross doesn't seem to have that much contrast.
or maybe it is just me?

@archbirdplus
Copy link
Contributor

See my PR on your PR. (?)

@IntegratedQuantum
Copy link
Member

I prefer the thin red cross.

@careeoki
Copy link
Contributor Author

I'm ready for this to be merged.
image

@du82
Copy link

du82 commented May 28, 2024

looks great! the X was bothering me before haha

@IntegratedQuantum IntegratedQuantum merged commit b7f701c into PixelGuys:master May 28, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI using block textures is too noisy Heart icon violates texture rules (132 excess colors in palette)
5 participants