-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Callback thread and reference #5
Labels
Comments
Any update on this? Callback should be on the main thread. Or the API could ask for the thread where callbacks should happen. |
The commits to improve this have been pushed. I'll deploy an update to Maven once I find my key... |
Is this on Gradle yet? :) |
Yup! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi,
This library looks really promising !
But as you mentioned in this commit : Pkmmte/TechDissected@47da228
it would be great if callback are called by default on the main thread. It looks very disturbing from the controller point of view to set a callback, call async, and get the result on a thread it did not create at all. I saw you implemented this on an 1.1.3 snapshot, is there any chance to get this release through maven ?
By the way, it would be also great to hold only weak references on callbacks, since we obviously do not want any fragment or activity held by the downloader and parser threads of your library.
The text was updated successfully, but these errors were encountered: