Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Callback thread and reference #5

Closed
vincentbrison opened this issue Jan 18, 2015 · 4 comments
Closed

Callback thread and reference #5

vincentbrison opened this issue Jan 18, 2015 · 4 comments
Assignees

Comments

@vincentbrison
Copy link

Hi,
This library looks really promising !

But as you mentioned in this commit : Pkmmte/TechDissected@47da228
it would be great if callback are called by default on the main thread. It looks very disturbing from the controller point of view to set a callback, call async, and get the result on a thread it did not create at all. I saw you implemented this on an 1.1.3 snapshot, is there any chance to get this release through maven ?

By the way, it would be also great to hold only weak references on callbacks, since we obviously do not want any fragment or activity held by the downloader and parser threads of your library.

@esoxjem
Copy link

esoxjem commented Jun 29, 2015

Any update on this? Callback should be on the main thread. Or the API could ask for the thread where callbacks should happen.

Pkmmte added a commit that referenced this issue Jul 6, 2015
@Pkmmte
Copy link
Owner

Pkmmte commented Jul 19, 2015

The commits to improve this have been pushed. I'll deploy an update to Maven once I find my key...

@esoxjem
Copy link

esoxjem commented Jul 29, 2015

Is this on Gradle yet? :)

@Pkmmte
Copy link
Owner

Pkmmte commented Sep 25, 2015

Yup!
Version 1.2 has been released a couple days ago on Maven.

@Pkmmte Pkmmte self-assigned this Sep 26, 2015
@Pkmmte Pkmmte closed this as completed Jan 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants