Implement media content parsing for RSS feeds #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request! Before I merge, I have one question: why did you decide to use a Vector instead of a synchronized List? |
|
My pleasure! I didn't use it because I didn't know about it. Now that I've read a bit more about Vectors in Java I'll change the code to a synchronized list. Vectors seem to be more or less deprecated. |
|
I'd appreciate it if you could modify your pull request to use a regular ArrayList instead. I don't think synchronization is really necessary for this. :) |
|
Sorry! It might take a few additional days to get this through. To much todo but not enough time :-) |
|
I'll go ahead and merge it anyway. I'll take care of modifying it. |
Pkmmte
added a commit
that referenced
this pull request
Jan 27, 2016
Implement media content parsing for RSS feeds
|
Thank you and sorry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've implemented media content parsing for RSS feeds.
More info here