Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api): add error codes coming from RemoteExceptions #172

Merged
merged 1 commit into from
Mar 28, 2022

Conversation

stakach
Copy link
Member

@stakach stakach commented Mar 28, 2022

found as part of an update to core-client

@stakach stakach added focus: backend Focus on Back End Development product: placeos Issue relates to PlaceOS Product squad: core PlaceOS Core Development priority: high labels Mar 28, 2022
@stakach stakach requested a review from caspiano March 28, 2022 01:59
@stakach stakach self-assigned this Mar 28, 2022
@github-actions github-actions bot added the type: bug something isn't working label Mar 28, 2022
@github-actions
Copy link

Hey, your PR is titled fix(api command): add error codes to coming from RemoteExceptions.
This is not a valid conventional commit.

Since we use well-formed PR titles for our changelogs, not fixing this can introduce problems :'(

@stakach stakach changed the title fix(api command): add error codes to coming from RemoteExceptions fix(api): add error codes coming from RemoteExceptions Mar 28, 2022
@github-actions github-actions bot added type: bug something isn't working and removed type: bug something isn't working labels Mar 28, 2022
@stakach stakach requested a review from tassja March 28, 2022 04:36
@stakach stakach merged commit 32edce9 into master Mar 28, 2022
@stakach stakach deleted the fix-error-code-propagation branch March 28, 2022 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
focus: backend Focus on Back End Development priority: high product: placeos Issue relates to PlaceOS Product squad: core PlaceOS Core Development type: bug something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants