Skip to content
This repository has been archived by the owner on Nov 15, 2022. It is now read-only.

Linter tweaks #28

Merged
merged 6 commits into from
Dec 4, 2020
Merged

Linter tweaks #28

merged 6 commits into from
Dec 4, 2020

Conversation

kimburgess
Copy link
Contributor

Adjust linter config to:

mghill
mghill approved these changes Dec 4, 2020
View reviewed changes
Copy link
Contributor

@mghill mghill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, closes out a lot of small issues plus a big one or two.

@kimburgess kimburgess merged commit 89abae5 into master Dec 4, 2020
@kimburgess kimburgess deleted the linter-tweaks branch December 4, 2020 03:43
mghill pushed a commit that referenced this pull request Dec 10, 2020
@kimburgess @mghill
Linter tweaks (#28)
244f132 
* flag write-good suggestions as warnings only

Previous config (default or error) would cause check status to fail.
This should instead be neutral, with the suggestion as an annotation.

* mark Rousseau suggestions as neutral

* remove duplication between rousseau and write-good

* add filter rule for idomatic terms

* ignore local package-lock.json files

* simplify acronyms regex
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mghill mghill mghill approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Linter incorrectly flags model numbers
2 participants
@kimburgess @mghill