Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make resource ID case sensitive - Fixes #75 #77

Merged
merged 1 commit into from
Apr 5, 2018
Merged

Make resource ID case sensitive - Fixes #75 #77

merged 1 commit into from
Apr 5, 2018

Conversation

MWL88
Copy link
Contributor

@MWL88 MWL88 commented Apr 4, 2018

This PR addresses issue #76

The ResourceLink (ResourceID variable) should not be converted to lowercase when creating the authorization token

@PlagueHO

@codecov
Copy link

codecov bot commented Apr 4, 2018

Codecov Report

Merging #77 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@        Coverage Diff        @@
##           dev   #77   +/-   ##
=================================
  Coverage   88%   88%           
=================================
  Files       11    11           
  Lines      591   591           
=================================
  Hits       521   521           
  Misses      70    70

@PlagueHO PlagueHO self-requested a review April 4, 2018 21:07
@PlagueHO PlagueHO self-assigned this Apr 4, 2018
@PlagueHO PlagueHO added in progress The issue is being actively worked on by someone. needs review The pull request needs a code review. labels Apr 4, 2018
@PlagueHO PlagueHO changed the title Make resource ID case sensitive Make resource ID case sensitive - Fixes #75 Apr 4, 2018
@PlagueHO
Copy link
Owner

PlagueHO commented Apr 4, 2018

Thank you very much @MWL88 - I'll review tonight after work and get this released to the Gallery ASAP.

@PlagueHO
Copy link
Owner

PlagueHO commented Apr 5, 2018

:lgtm:

I'll add a change log entry for this and then release straight away.

@PlagueHO PlagueHO merged commit 2c6e0db into PlagueHO:dev Apr 5, 2018
@MWL88 MWL88 deleted the fixauthztoken branch April 5, 2018 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PlagueHO PlagueHO PlagueHO approved these changes

Assignees

@PlagueHO PlagueHO

Labels
in progress The issue is being actively worked on by someone. needs review The pull request needs a code review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MWL88 @PlagueHO