Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add a warning message if there are no entrypoints #171

Merged
merged 1 commit into from
Sep 3, 2022

Conversation

nahtnam
Copy link
Contributor

@nahtnam nahtnam commented Sep 3, 2022

Details

Context: https://discord.com/channels/946290204443025438/978320682985349130/1015413639827705906

Code of Conduct

  • I agree to follow this project's Code of Conduct
  • I checked the current PR for duplication.

Testing

I only tested newtab.tsx, I'm going to assume the underlying initTemplateFile function works as expected

with newtab.tsx:

➜  with-newtab git:(8fa7fff) pnpm run build   

> with-newtab@0.0.0 build plasmo/examples/with-newtab
> plasmo build

🟣 Plasmo v0.52.5
🟠 The browser extension development framework.
🔵 INFO   | Prepare to bundle the extension...
🟢 DONE   | Finished in 2380ms!

after removing newtab.tsx:

➜  with-newtab git:(8fa7fff) pnpm run build

> with-newtab@0.0.0 build plasmo/examples/with-newtab
> plasmo build

🟣 Plasmo v0.52.5
🟠 The browser extension development framework.
🔵 INFO   | Prepare to bundle the extension...
🟠 WARN   | Unable to find any entrypoints. You may end up with an empty extension...
🟢 DONE   | Finished in 669ms!

Signed-off-by: Manthan Mallikarjun <nahtnam@gmail.com>
@nahtnam nahtnam marked this pull request as ready for review September 3, 2022 02:42
@louisgv louisgv changed the title Add a warning message if there are no entrypoints feat: add a warning message if there are no entrypoints Sep 3, 2022
Copy link
Contributor

@louisgv louisgv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@louisgv louisgv merged commit fbe4846 into PlasmoHQ:main Sep 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants