Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for remote interact #519

Merged
merged 15 commits into from
Apr 17, 2019
Merged

Add support for remote interact #519

merged 15 commits into from
Apr 17, 2019

Conversation

trinity-1686a
Copy link
Contributor

@trinity-1686a trinity-1686a commented Apr 8, 2019 •
edited
Loading

Add support for remote interaction (this thing in mastodon)

  • create the endpoint dispatching remote interactions to local pages
  • add this endpoint to web-finger
  • propose remote interaction when following and not connected
  • propose remote interaction when liking/sharing and not connected
  • propose remote interaction when commenting and not connected
  • fetch posts/comments we don't know but remote interaction was requested for ?

@trinity-1686a trinity-1686a added A: Federation Stuff related to Federation C: Feature This is a new feature S: Incomplete This PR is not complete yet labels Apr 8, 2019
@codecov
Copy link

codecov bot commented Apr 8, 2019 •
edited
Loading

Codecov Report

Merging #519 into master will decrease coverage by 1.56%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master     #519      +/-   ##
==========================================
- Coverage   42.48%   40.92%   -1.57%     
==========================================
  Files          68       68              
  Lines        9314     9823     +509     
==========================================
+ Hits         3957     4020      +63     
- Misses       5357     5803     +446

@trinity-1686a trinity-1686a mentioned this pull request Apr 8, 2019
Merged
@trinity-1686a
Propose remote follow when not connected
8c68d07 
With a terrible interface, and I think I forgot translations too 😬
@trinity-1686a
cargo fmt
f8dc6ef
igalic
igalic reviewed Apr 8, 2019
View reviewed changes
Copy link
Contributor

@igalic igalic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❓

Cargo.toml Show resolved Hide resolved
@elegaanz elegaanz added this to the Alpha 2 milestone Apr 17, 2019
elegaanz added a commit to Plume-org/docs that referenced this pull request Apr 17, 2019
@elegaanz
Basic federation guide
f97f5b6 
Fixes #16

Needs Plume-org/Plume#519 to be merged first
@elegaanz elegaanz mentioned this pull request Apr 17, 2019
Merged
@trinity-1686a trinity-1686a added the S: Blocked Something else needs to be fixed first label Apr 17, 2019
@trinity-1686a
Copy link
Contributor Author

blocked by #443

@trinity-1686a trinity-1686a removed the S: Blocked Something else needs to be fixed first label Apr 17, 2019
@trinity-1686a trinity-1686a added S: Ready for review This PR is ready to be reviewed and removed S: Incomplete This PR is not complete yet labels Apr 17, 2019
elegaanz
elegaanz approved these changes Apr 17, 2019
View reviewed changes
Copy link
Member

@elegaanz elegaanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@elegaanz elegaanz merged commit 0d708e1 into master Apr 17, 2019
@elegaanz elegaanz deleted the remote-interact branch April 17, 2019 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igalic igalic igalic left review comments

@elegaanz elegaanz elegaanz approved these changes

Assignees
No one assigned
Labels
A: Federation Stuff related to Federation C: Feature This is a new feature S: Ready for review This PR is ready to be reviewed
Projects
None yet
Milestone
Alpha 2
Development

Successfully merging this pull request may close these issues.
3 participants
@trinity-1686a @igalic @elegaanz