Marking Zig/solution_2 as unfaithful due to compile-time size fix #483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merging this to prevent (further) confusion about benchmark results. Also, the change can be easily reverted once the underlying reason has been addressed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As pointed out by a comment in discussion #445, the use of a combination of const and comptime in Zig/solution_2 boils down to the sieve (memory) size being set at compile time.
This goes against the rule that The sieve size and corresponding prime candidate memory buffer (or language equivalent) are set/allocated dynamically at runtime.
As @ManDeJan has indicated that they can change Zig/solution_2 to make it faithful, I'll hold on merging this PR for a few days to allow them to do so.