-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add route that serve status symbology #562
feat: add route that serve status symbology #562
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #562 +/- ##
===========================================
+ Coverage 50.90% 50.96% +0.06%
===========================================
Files 37 37
Lines 2377 2380 +3
===========================================
+ Hits 1210 1213 +3
Misses 1167 1167
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
fe3f769
to
bdec803
Compare
Se serait bien d'ajouter une mention à la route (et au choix de couleurs) dans la documentation : https://github.com/PnX-SI/TaxHub/blob/develop/docs/developpement.md |
bdec803
to
6c567a6
Compare
C'est ajouté. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK merci.
Si on se limite à la couleur, autant l'indiquer et le nommer comme ça dans la doc mais aussi le nom de la route ?
A moins qu'on puisse ajouter plus tard autre chose que de la couleur, mais je ne vois pas quoi.
6c567a6
to
e3a482b
Compare
Il s'agit du fix proposé dans l'issue GeoNature #3187
PnX-SI/GeoNature#3187 (comment)
Le principe est de servir la symbologie des statut au format json.
A terme, ce contenu sera intégré à la future route "status"
Ticket : #510