Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add route that serve status symbology #562

Conversation

edelclaux
Copy link
Contributor

@edelclaux edelclaux commented Sep 25, 2024

Il s'agit du fix proposé dans l'issue GeoNature #3187

PnX-SI/GeoNature#3187 (comment)

Le principe est de servir la symbologie des statut au format json.

A terme, ce contenu sera intégré à la future route "status"

Ticket : #510

@edelclaux edelclaux marked this pull request as draft September 25, 2024 15:31
Copy link

codecov bot commented Sep 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.96%. Comparing base (3fa37e9) to head (e3a482b).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #562      +/-   ##
===========================================
+ Coverage    50.90%   50.96%   +0.06%     
===========================================
  Files           37       37              
  Lines         2377     2380       +3     
===========================================
+ Hits          1210     1213       +3     
  Misses        1167     1167              
Flag Coverage Δ
pytest 50.96% <100.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edelclaux edelclaux force-pushed the feat/add-route-that-serve-status-symbology branch 3 times, most recently from fe3f769 to bdec803 Compare September 26, 2024 09:54
@edelclaux edelclaux marked this pull request as ready for review September 26, 2024 10:00
@amandine-sahl
Copy link
Contributor

Se serait bien d'ajouter une mention à la route (et au choix de couleurs) dans la documentation : https://github.com/PnX-SI/TaxHub/blob/develop/docs/developpement.md

@edelclaux edelclaux force-pushed the feat/add-route-that-serve-status-symbology branch from bdec803 to 6c567a6 Compare October 2, 2024 09:46
@edelclaux
Copy link
Contributor Author

Se serait bien d'ajouter une mention à la route (et au choix de couleurs) dans la documentation : https://github.com/PnX-SI/TaxHub/blob/develop/docs/developpement.md

C'est ajouté.

Copy link
Member

@camillemonchicourt camillemonchicourt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK merci.
Si on se limite à la couleur, autant l'indiquer et le nommer comme ça dans la doc mais aussi le nom de la route ?
A moins qu'on puisse ajouter plus tard autre chose que de la couleur, mais je ne vois pas quoi.

apptax/taxonomie/routesbdcstatuts.py Outdated Show resolved Hide resolved
@edelclaux edelclaux force-pushed the feat/add-route-that-serve-status-symbology branch from 6c567a6 to e3a482b Compare October 2, 2024 11:07
@jacquesfize jacquesfize merged commit bebf081 into PnX-SI:develop Oct 3, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants