Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add: get boardMaxid / boards post handling #4

Merged
merged 2 commits into from
Jun 5, 2022
Merged

add: get boardMaxid / boards post handling #4

merged 2 commits into from
Jun 5, 2022

Conversation

AbdelkarimBENGRINE
Copy link
Contributor

@AbdelkarimBENGRINE AbdelkarimBENGRINE commented Jun 5, 2022 •
edited
Loading

Description

Please provide a detailed description of what was done in this PR.
Precise the issue that you are resolving.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Breaking changes

Please complete this section if any breaking changes have been made, otherwise delete it.

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the needed labels
  • I have linked this PR to an issue
  • I have linked this PR to a milestone
  • I have linked this PR to a project
  • I have tested this code
  • I have added / updated tests (unit / functionals / end-to-end / ...)
  • I have updated the README and other relevant documents (guides...)
  • I have added sufficient documentation both in code, as well as in the READMEs

Additional comments

Please post additional comments in this section if you have them, otherwise delete it.

@AbdelkarimBENGRINE AbdelkarimBENGRINE added the enhancement New feature or request label Jun 5, 2022
@AbdelkarimBENGRINE AbdelkarimBENGRINE self-assigned this Jun 5, 2022
Doozers
Doozers reviewed Jun 5, 2022
View reviewed changes
Copy link
Contributor

@Doozers Doozers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Doozers Doozers merged commit c6bfa38 into main Jun 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Doozers Doozers Doozers left review comments

@OnsagerHe OnsagerHe Awaiting requested review from OnsagerHe

Assignees

@AbdelkarimBENGRINE AbdelkarimBENGRINE

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AbdelkarimBENGRINE @Doozers