Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly decode download requests as UTF-8. #982

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gibbed
Copy link

@gibbed gibbed commented Jun 10, 2019

This adjusts the return value of PoEScripts_Download so that it properly decodes UTF-8 data, allowing TradeMacro to properly handle Korean character names.

Currently search results have heavy use of StrPad for formatting, which this change butts right up against and will require further rework of tooltip rendering for these before this fix should be merged.

unknown

As far as I can tell, all calls to PoEScripts_Download don't specify or otherwise ask for an encoding of UTF-8.

I left the default encoding as CP850 to retain the previous behavior for unmodified calls to StdOutStream.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant