Block rendering additions #905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Java : NESW : 0,1,2,3 Bedrock : NESW : 3,4,2,5
Added the bottom texture to oak and iron doors. The other door types use the full block render. Open doors render odd because the top block uses a different data value to that of Java which breaks the render (uses the same as when closed)
Added texture for Jukebox Removed barrier block as sub-block of glass and added the texture to invisible bedrock as they serve essentially the same purpose
Coppied over Magma, Nether Wart Block, Red Nether Brick and Bone Block
Gave shulker boxes their own texture rather than using the concrete texture Added entry for normal shulker boxes (they have 2 ids - 205 for normal and 218 for coloured)
Added an entry for item frames. Renderer could do with a method to better show the direction the item frame is facing
Pistons facing horisontally needed their direction changing. Removed higher data values that seem to have been coppied from Java but are not used in Bedrock. Added a 50:50 normal:sticky texture for the piston extension since the same block is shared for both. Ideally a custom renderer would access the connected block to get the correct texture but this is beyond my knowledge
LaChal
approved these changes
Feb 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a bunch of blocks rendering as the default purple box for the Bedrock codebase and added block names