Skip to content
This repository has been archived by the owner on Oct 30, 2024. It is now read-only.

ICantBelieveItsNotValetudo Fork with support for mutliple robots #283

Closed
derrohrbach opened this issue Nov 24, 2021 · 3 comments
Closed
Labels
ICantBelieveItsNotValetudo ICantBelieveItsNotValetudo Addon

Comments

@derrohrbach
Copy link

Which addon?
ICantBelieveItsNotValetudo

Is your feature request related to a problem? Please describe.
Running multiple instances for multiple robots

Describe the solution you'd like
I implemented a fork of ICantBelieveItsNotValetudo which supports mutliple configs for people with multiple robots. I'd like to talk about how and if we should work together to get it into this repo and solve multiple robots forever. Sadly Hypfer did not accept my PR into mainline ICantBelieveItsNotValetudo, so it'll have to stay a fork. The question is do you want to include it or do we just continue to use workarounds like my other fork of this addon repo which adds a second instance of the app.

Describe alternatives you've considered

I developed a fork of this addon repo, which just includes a second instance of ICantBelieveItsNotValetudo
https://github.com/derrohrbach/Hassio-Addons
--> I think this is a workaround and discoverability for other users is bad!

I developed a fork of ICantBelieveItsNotValetudo which supports multiple configs
https://github.com/derrohrbach/ICantBelieveItsNotValetudo
--> Was sadly not accepted: Hypfer/ICantBelieveItsNotValetudo#76

This is also related to:
#271

@Poeschl Poeschl added the ICantBelieveItsNotValetudo ICantBelieveItsNotValetudo Addon label Nov 24, 2021
@github-actions
Copy link

Hi, there.

Please make sure you have the right addon for your software.
The addon you mentioning is the companion for ICantBelieveItsNotValetudo from Hypfer.


This is an automated comment. Responding to the bot or mentioning it won't have any effect.

@Poeschl
Copy link
Owner

Poeschl commented Nov 28, 2021

I wouldn't name your fork of Valetudo a workaround. Since it will not get merged into ICBINV it becomes a separate, specialized project.
For myself I don't see the need to include it in my collection. Nevertheless feel free to make an own addon repository which contains your multi instance build.

I thought a few times about just starting a few instances of ICBINV inside of one addon, but the configuration was is not possible because auf the yaml config nesting limit of HA.

@stale
Copy link

stale bot commented Dec 7, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Dec 7, 2021
@stale stale bot closed this as completed Dec 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
ICantBelieveItsNotValetudo ICantBelieveItsNotValetudo Addon
Projects
None yet
Development

No branches or pull requests

2 participants