Switch to using client-based search in Doxygen #2391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jspricke
approved these changes
Aug 18, 2018
|
The search works for me in Chromium, but fails with JavaScript errors in Firefox. However, when I generate documentation locally (with Doxygen 1.8.11), the search works in Firefox as well. |
|
Travis uses Doxygen 1.8.6, maybe upgrade that one or even upgrade Travis to 18.04. |
|
Strange. Even though we did not change anything in the meantime and also there were no new Firefox releases, the search at http://docs.pointclouds.org/trunk does work for me now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in PointCloudLibrary/documentation#1, documentation search does not work. It looks like execution of PHP scripts (which power server-side search) was disabled, which I suspect has happened while solving #2381.
This commit enables client-side JavaScript-based search.