-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use nullptr in module visualization #3029
Use nullptr in module visualization #3029
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if we should modify the "cxx" files from vtk/
directory. These were directly copied from VTK source tree. @SergioRAgostinho what do you think?
Do you have any idea on what's the story behind these files? Here's what I found Some relevant commits: Answering your question, I think we should approve the changes to these special files and simultaneously open an issue into investigating if these files can actually be stripped out of our source tree. I suspect that ultimately, we're gonna find that someone made some custom changes which won't allow us to easily remove them. If changes were indeed made and there are evidences suggesting that, then there's no reason to worry about further "tainting" the code with more changes. |
visualization/include/pcl/visualization/impl/pcl_visualizer.hpp
Outdated
Show resolved
Hide resolved
visualization/include/pcl/visualization/impl/pcl_visualizer.hpp
Outdated
Show resolved
Hide resolved
visualization/include/pcl/visualization/impl/pcl_visualizer.hpp
Outdated
Show resolved
Hide resolved
visualization/include/pcl/visualization/impl/pcl_visualizer.hpp
Outdated
Show resolved
Hide resolved
…dernize-use-nullptr' -fix
8451523
to
b55312b
Compare
No, these files date back too far, I have no knowledge of them. But I agree with what you wrote. |
Changes are done by run-clang-tidy -header-filter='.' -checks='-,modernize-use-nullptr' -fix