Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use nullptr in module visualization #3029

Conversation

SunBlack
Copy link
Contributor

Changes are done by run-clang-tidy -header-filter='.' -checks='-,modernize-use-nullptr' -fix

Copy link
Member

@taketwo taketwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if we should modify the "cxx" files from vtk/ directory. These were directly copied from VTK source tree. @SergioRAgostinho what do you think?

@SergioRAgostinho
Copy link
Member

Do you have any idea on what's the story behind these files? Here's what I found

The history:
https://github.com/PointCloudLibrary/pcl/commits/84515237c3d4c692ccde559338b9e040828b401b/visualization/src/vtk/vtkVertexBufferObject.cxx

Some relevant commits:
Addition of the vtk source tree files - 2e5624d#diff-8e3e87eb9884b3bc2dc078e300a79c1d
The initial commit of this 2d canvas object - ff81eba#diff-5fe104abeeaaf3fa0b0c27ef1e5e5c64

Answering your question, I think we should approve the changes to these special files and simultaneously open an issue into investigating if these files can actually be stripped out of our source tree. I suspect that ultimately, we're gonna find that someone made some custom changes which won't allow us to easily remove them. If changes were indeed made and there are evidences suggesting that, then there's no reason to worry about further "tainting" the code with more changes.

visualization/src/image_viewer.cpp Outdated Show resolved Hide resolved
visualization/src/pcl_visualizer.cpp Outdated Show resolved Hide resolved
visualization/src/pcl_visualizer.cpp Outdated Show resolved Hide resolved
visualization/src/pcl_visualizer.cpp Outdated Show resolved Hide resolved
visualization/src/pcl_visualizer.cpp Outdated Show resolved Hide resolved
visualization/src/point_picking_event.cpp Outdated Show resolved Hide resolved
@SunBlack SunBlack force-pushed the modernize-use-nullptr_visualization branch from 8451523 to b55312b Compare April 25, 2019 14:50
@taketwo
Copy link
Member

taketwo commented Apr 25, 2019

No, these files date back too far, I have no knowledge of them. But I agree with what you wrote.

@SergioRAgostinho SergioRAgostinho merged commit 711b121 into PointCloudLibrary:master Apr 27, 2019
@SunBlack SunBlack deleted the modernize-use-nullptr_visualization branch April 28, 2019 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants