Suppress Multiple Warnings #3427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SergioRAgostinho
force-pushed
the
warnings
branch
from
59f3449
to
1178bb3
Compare
|
1 and 5 do appear to be bugs. |
This was referenced Oct 21, 2019
SergioRAgostinho
force-pushed
the
warnings
branch
from
1178bb3
to
fa6081c
Compare
kunaltyagi
approved these changes
Oct 25, 2019
|
One more down for 1.10 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey guys. I'm planning on addressing some of the pending items in the updated release goals. As usual, I enjoy working with from a warning free state, so I patched some of the things which were spewing warnings with GCC 7. I believe some are actual bugs, hence me publishing this as a draft PR, to that we can cherry pick how to organize the PRs.
Imo commits 1, 3 and 5 are actually bugs.