-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OpenNI apps: Improve handling of command line arguments #5494
Conversation
Then perhaps we should do that in a new PR 👍 |
You are right - sorry, I must have been extremely sleepy in any case, deal! I will work on it after this is merged, thanks for the review :) |
@sfilbertf could you please rebase and then I think its 🚀 |
Hey, I think it should be done :) |
I think it's a bit problematic that, if users update PCL but try to use the old syntax |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Edit: Done! Sorry, I didn't know drafts were a thing. .
Side notes:
openni_color_filter.cpp
as well asopenni_tracking.cpp
to fit the rest of the files (default values as well as structure)openni_color_filter.cpp
- [] for optional params, < and > for required params, etc.)General changes are (just a checklist to ease the review):
if (argc < 2)
device_id
be an optional parameter initialized with an empty string, and updatearg
s todevice_id
s