You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Now that #5475 is closed, I hope to able able to make following changes:
As several maintainers pointed out, currently,
Several files require you to input -h to be able to get the output of usage(), some allow -h and --help
(compare openni_3d_convex_hull.cpp and openni_voxel_grid.cpp)
The variable name arg is used for both device_id and -h or --help
(see openni_3d_convex_hull.cpp)
For some files, --help or -help can only be used to call usage() if they are the first arguments in the cmd line, some use pcl::console::find_argument(argc, argv, "-h"), where it could be anywhere (same example as 1.)
options is shown for the output of usage() for some files where no options can be given
(compare openni_3d_convex_hull.cpp and openni_ii_normal_estimation.cpp, where options is not displayed if options can't be used in main().
Idea:
So that everything says uniform, use std::string device_id instead of std::string arg exclusively for the device id, make it have to be at argv[1] (while checking if it begins with '-' as to not confuse it with options parameter -> see openni_planar_convex_hull.cpp), initialize it to the default value "" so that device_id can safely be passed everytime (grabber looks for first device), allowing it to be optional when its not a cmd line arg and separate it completely from -h or --help (can be at any position, using pcl::console::find_argument(argc, argv, "-h") bzw. pcl::console::find_argument(argc, argv, "--help"))
+Make small changes by deleting options in usage() where none can/needs to be passed
I think it would be a good idea to start with the same files worked on the last time:
Now that #5475 is closed, I hope to able able to make following changes:
As several maintainers pointed out, currently,
-h
to be able to get the output of usage(), some allow-h
and--help
(compare
openni_3d_convex_hull.cpp
andopenni_voxel_grid.cpp
)device_id
and-h
or--help
(see
openni_3d_convex_hull.cpp
)--help
or-help
can only be used to callusage()
if they are the first arguments in the cmd line, some usepcl::console::find_argument(argc, argv, "-h")
, where it could be anywhere (same example as 1.)usage()
for some files where no options can be given(compare
openni_3d_convex_hull.cpp
andopenni_ii_normal_estimation.cpp
, where options is not displayed if options can't be used inmain()
.Idea:
So that everything says uniform, use
std::string device_id
instead ofstd::string arg
exclusively for the device id, make it have to be atargv[1]
(while checking if it begins with '-' as to not confuse it with options parameter -> seeopenni_planar_convex_hull.cpp
), initialize it to the default value "" so thatdevice_id
can safely be passed everytime (grabber looks for first device), allowing it to be optional when its not a cmd line arg and separate it completely from-h
or--help
(can be at any position, usingpcl::console::find_argument(argc, argv, "-h")
bzw.pcl::console::find_argument(argc, argv, "--help")
)+Make small changes by deleting options in
usage()
where none can/needs to be passedI think it would be a good idea to start with the same files worked on the last time:
The text was updated successfully, but these errors were encountered: