Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using an unsupported keyword gives an error (but not the right one) #186

Closed
tpoisot opened this issue May 6, 2023 · 0 comments · Fixed by #193
Closed

Using an unsupported keyword gives an error (but not the right one) #186

tpoisot opened this issue May 6, 2023 · 0 comments · Fixed by #193
Labels
bug Something isn't working component:SimpleSDMDatasets triage

Comments

@tpoisot
Copy link
Member

tpoisot commented May 6, 2023

Using e.g.

provider = RasterData(WorldClim2, BioClim)
layers = [SimpleSDMPredictor(provider; layers=i, bbox...) for i in (1,8)]

gives an error because layers is not a valid keyword, but it's not the error we should get. Need to fix the keychecker function.
tpoisot added a commit that referenced this issue May 14, 2023
@tpoisot
semver(datasets): v0.1.1
c4c808a 
Closes #186
@tpoisot tpoisot mentioned this issue May 14, 2023
Merged
tpoisot added a commit that referenced this issue May 14, 2023
@tpoisot
bug(datasets): keychecker fails to check some wrong arguments (#193)
dd9248f 
* semver(datasets): v0.1.1

Closes #186

* ci(sdt): add the keychecker unit test

* ci(sdt): add the test for the wrong layer argument

* bug(datasets): correctly catches keywords that are not supported

* ci(datasets): fix the unit test to catch the correct error

* bug(datasets): fix a typo in the unit test error message
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working component:SimpleSDMDatasets triage
Projects
Species Distribution Toolkit
Status: Done
Milestone
No milestone
1 participant
@tpoisot