Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(datasets): keychecker fails to check some wrong arguments #193

Merged
merged 6 commits into from
May 14, 2023

Conversation

tpoisot
Copy link
Member

@tpoisot tpoisot commented May 14, 2023

Closes #186

@github-actions
Copy link
Contributor

@codecov-commenter
Copy link

codecov-commenter commented May 14, 2023

Codecov Report

Patch coverage: 10.00% and project coverage change: +5.83 🎉

Comparison is base (385831f) 47.53% compared to head (b7ae751) 53.36%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #193      +/-   ##
==========================================
+ Coverage   47.53%   53.36%   +5.83%     
==========================================
  Files          47       59      +12     
  Lines        1378     1692     +314     
==========================================
+ Hits          655      903     +248     
- Misses        723      789      +66     
Flag Coverage Δ
unittests 53.36% <10.00%> (+5.83%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
SimpleSDMDatasets/src/keychecker.jl 70.96% <10.00%> (ø)

... and 11 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tpoisot tpoisot marked this pull request as ready for review May 14, 2023 16:45
@tpoisot tpoisot merged commit dd9248f into main May 14, 2023
@tpoisot tpoisot deleted the sdt/bug/keychecker branch May 14, 2023 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using an unsupported keyword gives an error (but not the right one)
2 participants