Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gen 7 location areas #1014

Merged
merged 4 commits into from
Jan 20, 2024
Merged

Conversation

DaltonSW
Copy link
Contributor

  • Added Generation 7 location areas
  • Added locations needed to round out all of the location areas
  • actually figured out how to rebuild the database locally finally to fully test my changes on the running API :)
    image

@Naramsim
Copy link
Member

Hmm, we have conflicts, maybe I shouldn't have merged the other PR. Are you able to resolve them?

@Naramsim Naramsim merged commit f78326c into PokeAPI:master Jan 20, 2024
3 checks passed
@pokeapi-machine-user
Copy link

A PokeAPI/api-data refresh has started. In ~45 minutes the staging branch of PokeAPI/api-data will be pushed with the new generated data.

The staging branch will be deployed in our staging environment and the entire API will be ready to review.

A Pull Request (master<-staging) will be also created at PokeAPI/api-data and assigned to the PokeAPI Core team to be reviewed. If approved and merged new data will soon be available worldwide at pokeapi.co.

@pokeapi-machine-user
Copy link

The updater script has finished its job and has now opened a Pull Request towards PokeAPI/api-data with the updated data.

The Pull Request can be seen deployed in our staging environment when CircleCI deploy will be finished (check the start time of the last build).

@DaltonSW DaltonSW deleted the add-gen-7-location-areas branch January 20, 2024 23:10
Naramsim pushed a commit to PokeAPI/api-data that referenced this pull request Jan 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants