Skip to content
This repository has been archived by the owner on Oct 2, 2023. It is now read-only.

Add translations for sword/shield abilities and moves #29

Merged

Conversation

Parnassius
Copy link

I put the two scripts I used in pokeapi/scripts/gen8, both are based on the files already there.

This should close #27 and #28 as well

@Naramsim
Copy link
Member

Thanks a lot! I merged just before a fix for the French language.

I see this PR brings in more languages, but I'd like to discuss here a bit the Chinese changes.

In my opinion, we need to support a third language.

Right now we have Traditional Chinese and Simplified Chinese. But on Bulbapedia we have three variants: 1 for Cantonese and 2 for Mandarin. Out of those two Mandarin, I suspect one is Traditional Chinese. I have a Chinese friend so I'll try to ask her what we should do here.

@Naramsim
Copy link
Member

Ok I can confirm, there are three languages.

Cantonese
Mandarin (traditional)
Mandarin (simplified)

Those are presented in the order above on Bulbapedia. So we need to think about how to go on with this PR.

@Parnassius
Copy link
Author

The problem is sword/shield data files (and sm/usum as well, not sure about let's go) only contain 2 folders, not three. Language id 4 (called Traditional chinese in-game) seems to correspond to Cantonese, and language id 12 (Simplified chinese in-game) to Mandarin traditional in sm/usum and Mandarin simplified in letsgo/sword/shield. For example https://bulbapedia.bulbagarden.net/wiki/Shift_Gear_(move)#In_other_languages seems to confirm this (see the tooltips next to the chinese translations).

Honestly I would simply replace them, since names used in old games are not in the CSVs, and for example abilities didn't change at all, but obviously it's not my call to make

@Naramsim
Copy link
Member

Ok, let's merge this PR.

@Naramsim Naramsim merged commit 43ea745 into PokeAPI:master-pokeapi May 12, 2021
Naramsim added a commit to PokeAPI/pokeapi that referenced this pull request May 12, 2021
@Parnassius Parnassius deleted the abilities-moves-translations branch October 17, 2021 12:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move name changes for generation 8
2 participants