Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Question navigation during test is broken #93

Closed
EndBug opened this issue Apr 28, 2023 · 4 comments · Fixed by #91
Closed

Question navigation during test is broken #93

EndBug opened this issue Apr 28, 2023 · 4 comments · Fixed by #91
Labels
type: bug Verified problems that need to be worked on
Milestone
2

Comments

@EndBug
Copy link
Member

EndBug commented Apr 28, 2023

Some of the previous PRs borke the question navigation: if you try to change the question by clicking on the number the page goes back to the homepage.
@EndBug EndBug added the type: bug Verified problems that need to be worked on label Apr 28, 2023
@EndBug EndBug added this to the 2 milestone Apr 28, 2023
@EndBug
Copy link
Member Author

EndBug commented Apr 28, 2023

git bisect shows that the firsy bad commit is 6dbd3cf, the merge commit of pr #81

@EndBug
Copy link
Member Author

EndBug commented Apr 28, 2023

@lorenzocorallo Is there a way we can fix this? Can you look into it?

@lorenzocorallo
Copy link
Contributor

I had already opened PR #91 which fixes the bug, if I understood correctly what you are reporting

@EndBug EndBug mentioned this issue Apr 28, 2023
Merged
@EndBug
Copy link
Member Author

EndBug commented Apr 28, 2023

Yeah, that was it, thanks 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: bug Verified problems that need to be worked on
Projects
None yet
Milestone
2
Development

Successfully merging a pull request may close this issue.

fix(RecapBar): fix question switch via RecapBar lorenzocorallo/TheTOLProject
2 participants
@EndBug @lorenzocorallo