Massachusetts Emergency Aid to the Elderly, Disabled and Children (EAEDC) #4870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PavelMakarchuk
requested changes
Aug 15, 2024
policyengine_us/parameters/gov/states/ma/dta/tcap/eaedc/age_threshold.yaml
Outdated
Show resolved
Hide resolved
policyengine_us/parameters/gov/states/ma/dta/tcap/eaedc/age_threshold.yaml
Outdated
Show resolved
Hide resolved
policyengine_us/variables/gov/states/ma/dta/tcap/eaedc/income/ma_eaedc_net_income.py
Outdated
Show resolved
Hide resolved
hua7450
commented
Aug 15, 2024
policyengine_us/variables/gov/states/ma/dta/tcap/eaedc/income/ma_eaedc_net_income.py
Outdated
Show resolved
Hide resolved
policyengine_us/variables/gov/states/ma/dta/tcap/eaedc/income/ma_eaedc_income_limit.py
Outdated
Show resolved
Hide resolved
policyengine_us/variables/gov/states/ma/dta/tcap/eaedc/income/ma_eaedc_income_limit.py
Outdated
Show resolved
Hide resolved
hua7450
commented
Aug 22, 2024
...cyengine_us/variables/gov/states/ma/dta/tcap/eaedc/income/ma_eaedc_disabled_earned_income.py
Outdated
Show resolved
Hide resolved
hua7450
commented
Aug 22, 2024
policyengine_us/variables/gov/states/ma/dta/tcap/eaedc/income/ma_eaedc_earned_income.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Pinyan <pxu12@users.noreply.github.com>
Merge branch 'master' of https://github.com/PolicyEngine/policyengine-us into hua7450/issue1712
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4870 +/- ##
==========================================
+ Coverage 99.00% 99.02% +0.01%
==========================================
Files 2536 2572 +36
Lines 36845 37364 +519
Branches 152 158 +6
==========================================
+ Hits 36479 36998 +519
Misses 337 337
Partials 29 29 ☔ View full report in Codecov by Sentry. |
Merge branch 'master' of https://github.com/PolicyEngine/policyengine-us into hua7450/issue1712
PavelMakarchuk
requested changes
Aug 29, 2024
| class ma_eaedc_disabled_earned_income(Variable): | ||
| value_type = float | ||
| entity = Person | ||
| label = "Massachusetts EAEDC disabled earned income" |
There was a problem hiding this comment.
Suggested change
| label = "Massachusetts EAEDC disabled earned income" | |
| label = "Massachusetts EAEDC earned income of a disabled person" |
| from policyengine_us.model_api import * | ||
|
|
||
|
|
||
| class ma_eaedc_total_earned_income(Variable): |
There was a problem hiding this comment.
Suggested change
| class ma_eaedc_total_earned_income(Variable): | |
| class ma_eaedc_no_disabled_earned_income(Variable): |
| from policyengine_us.model_api import * | ||
|
|
||
|
|
||
| class ma_eaedc_earned_income(Variable): |
There was a problem hiding this comment.
Suggested change
| class ma_eaedc_earned_income(Variable): | |
| class ma_eaedc_total_earned_income(Variable): |
| definition_period = YEAR | ||
| defined_for = StateCode.MA | ||
|
|
||
| adds = ["ma_eaedc_earned_income"] |
There was a problem hiding this comment.
make a formula and lets do the same as in disabled income just with ~disabled & ~dependent
| person = spm_unit.members | ||
| is_dependent = person("is_tax_unit_dependent", period) | ||
| age = person("age", period) | ||
| meets_age_limit = age < 18 |
There was a problem hiding this comment.
lets parametrize this
| value_type = bool | ||
| entity = SPMUnit | ||
| label = "Eligible for Massachusetts EAEDC dependent care deduction" | ||
| unit = USD |
There was a problem hiding this comment.
Suggested change
| unit = USD |
| value_type = bool | ||
| entity = SPMUnit | ||
| label = "Disabled person's income eligible for Massachusetts EAEDC" | ||
| unit = USD |
There was a problem hiding this comment.
Suggested change
| unit = USD |
| value_type = bool | ||
| entity = SPMUnit | ||
| label = "Assets eligible for Massachusetts EAEDC " | ||
| unit = USD |
There was a problem hiding this comment.
Suggested change
| unit = USD |
| value_type = bool | ||
| entity = SPMUnit | ||
| label = "Age eligible for Massachusetts EAEDC " | ||
| unit = USD |
There was a problem hiding this comment.
Suggested change
| unit = USD |
| defined_for = StateCode.MA | ||
|
|
||
| def formula(person, period, parameters): | ||
| disabled = person("is_disabled", period) |
There was a problem hiding this comment.
add a is_dependent condition
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1712