Initial commit #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
April 3, 2019 18:09
|
@grant-d Many thanks for this! I will get to this for review as soon as I can. |
src/Polly.Contrib.WaitAndRetry.Specs/ExponentialBackoffSpecs.cs
Outdated
Show resolved
Hide resolved
src/Polly.Contrib.WaitAndRetry.Specs/ExponentialBackoffSpecs.cs
Outdated
Show resolved
Hide resolved
|
Huge thanks for your time on this @grant-d . Looking lovely to me. 👍 (Commented some tiny things - apologies for separate email comments - meant to |
|
No problem, CR fixes complete |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@reisenberger please would you take a look at this.
The initial commit for this repo, which I created by using the provided template.
I am not familiar with your build system, versioning & other conventions so all comments welcome.
If it's easier, feel free to push directly to this PR, else I can merge then you can edit in a separate PR.
If you can please ensure it's using a preview version no so that we don't publish a release Nuget yet
Would you mind setting up CI & any policies you use on the main repo (Set up CI #4 )
Resolves #3