Bugfix for Temperature correction #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Bugfixes: add Klett Bsc NR Insert the metadata of Klett Bsc NR figure to the done_filelist. close #116 * Bugfixes: show nr Klett profiles Fix bugs associated with missing near-field profiles with Klett method. Update the version `3.2` to identify this change. Close #116 * Andi branch 01 (#121) * added database param -AutoCommit- and value -off- in var. conn and commited out set(conn,...)-function * added database param -AutoCommit- and value -off- in var. conn and commited out set(conn,...)-function continued * added matlab-version check to correctly set database connection parameters * added variable tilt_angle * replaced function split with function strsplit to get the release-version Co-authored-by: ulysses78 <andiklamt78@yahoo.de> * Added near-range SNR * incorporated requested chagens from pull reqeust Co-authored-by: Zhenping <zp.yin@whu.edu.cn> Co-authored-by: Holger Baars <55800803+HolgerPollyNet@users.noreply.github.com> Co-authored-by: ulysses78 <andiklamt78@yahoo.de>
* Added near-range quality mask * Added near range quality mask * Added near range quality mask
associate with #131 (comment)
…lization of 1064 depol products
- Implement of 1064 depol for pollyxt_cpv - Revise code style of python script - Add prompts for data visualization
* Homogenization of variable names for OC (overlap corected) and NR (near-range) files (#133) * Added near-range SNR to pollySaveNRAttnBeta plus older commits (#125) * Bugfixes: add Klett Bsc NR Insert the metadata of Klett Bsc NR figure to the done_filelist. close #116 * Bugfixes: show nr Klett profiles Fix bugs associated with missing near-field profiles with Klett method. Update the version `3.2` to identify this change. Close #116 * Andi branch 01 (#121) * added database param -AutoCommit- and value -off- in var. conn and commited out set(conn,...)-function * added database param -AutoCommit- and value -off- in var. conn and commited out set(conn,...)-function continued * added matlab-version check to correctly set database connection parameters * added variable tilt_angle * replaced function split with function strsplit to get the release-version Co-authored-by: ulysses78 <andiklamt78@yahoo.de> * Added near-range SNR * incorporated requested chagens from pull reqeust Co-authored-by: Zhenping <zp.yin@whu.edu.cn> Co-authored-by: Holger Baars <55800803+HolgerPollyNet@users.noreply.github.com> Co-authored-by: ulysses78 <andiklamt78@yahoo.de> * Added near-range quality mask (#128) * Added near-range quality mask * Added near range quality mask * Added near range quality mask * Dev (#129) * Added near-range quality mask * Added near range quality mask * Added near range quality mask * Changed file name to default name Co-authored-by: griesche <48522799+griesche@users.noreply.github.com> Co-authored-by: Holger Baars <55800803+HolgerPollyNet@users.noreply.github.com> Co-authored-by: ulysses78 <andiklamt78@yahoo.de> * Bugfixes: (quasi) angstroem plot Bug Description --------------- No plots of quasi-angstroem exponent after moving to Picasso v3.x. Bug Analysis ------------ Wrong implementation of channel existence check for 1064 total. ``` matlab flag1064 = data.flagFarRangeChannel & data.flag1064nmChannel & data.flagCrossChannel; % before ``` Bug Fixes --------- Fix channel existence check, as below: ``` matlab flag1064 = data.flagFarRangeChannel & data.flag1064nmChannel & data.flagTotalChannel; ``` close #134 * Bugfixes: replace empty/invalid gdas1 data Replace invalid/empty GDAS1 profiles with profiles from standard atmosphere. Close #135 * Bugfixes: correct meteor filter Check for invalid meteorological data in last [commit](3f02c5b) is wrong, as `~ any(isnan(alt))` condition check would filter meteorological profile containing any NaN height level. The idea for this check is to detect profile which is empty, all NaNs or only one unique height level. Therefore, this check was corrected as below, ``` matlab % previous isempty(alt) || (~ any(isnan(alt))) || (length(unique(alt)) < 2) % now isempty(alt) || (~ all(isnan(alt))) || (length(unique(alt)) < 2) ``` associated with #135 * bug fixed of new meteor filter, ~ was wrong * added 1064 nm, saving and displaying still missing, minor spell checking * added saving of 1064s vertical profiles to netcdf. * minor bug fixing, adding saving of 1064 depol products, started visualization of 1064 depol products * added displaying of 1064 depol * added some print_msg, to find out at which postition it takes that long time * final changes for 1064s implementation * bugfixes: minor fixes on 1064 depol * Feat: 1064 depol (beta) - Implement of 1064 depol for pollyxt_cpv - Revise code style of python script - Add prompts for data visualization Co-authored-by: griesche <48522799+griesche@users.noreply.github.com> Co-authored-by: Holger Baars <55800803+HolgerPollyNet@users.noreply.github.com> Co-authored-by: ulysses78 <andiklamt78@yahoo.de> Co-authored-by: Baymax <test@email.com> Co-authored-by: Holger Baars <baars@tropos.de>
…_Chain into holger_3 # Conflicts: # lib/visualization/pollyDisplayProfiles.m
minor bug fixing for the implementation of the 1064 depol. And changes the storage of shots from int16 to int32, because partly more shots are used.
at different place
* Homogenization of variable names for OC (overlap corected) and NR (near-range) files (#133) * Added near-range SNR to pollySaveNRAttnBeta plus older commits (#125) * Bugfixes: add Klett Bsc NR Insert the metadata of Klett Bsc NR figure to the done_filelist. close #116 * Bugfixes: show nr Klett profiles Fix bugs associated with missing near-field profiles with Klett method. Update the version `3.2` to identify this change. Close #116 * Andi branch 01 (#121) * added database param -AutoCommit- and value -off- in var. conn and commited out set(conn,...)-function * added database param -AutoCommit- and value -off- in var. conn and commited out set(conn,...)-function continued * added matlab-version check to correctly set database connection parameters * added variable tilt_angle * replaced function split with function strsplit to get the release-version Co-authored-by: ulysses78 <andiklamt78@yahoo.de> * Added near-range SNR * incorporated requested chagens from pull reqeust Co-authored-by: Zhenping <zp.yin@whu.edu.cn> Co-authored-by: Holger Baars <55800803+HolgerPollyNet@users.noreply.github.com> Co-authored-by: ulysses78 <andiklamt78@yahoo.de> * Added near-range quality mask (#128) * Added near-range quality mask * Added near range quality mask * Added near range quality mask * Dev (#129) * Added near-range quality mask * Added near range quality mask * Added near range quality mask * Changed file name to default name Co-authored-by: griesche <48522799+griesche@users.noreply.github.com> Co-authored-by: Holger Baars <55800803+HolgerPollyNet@users.noreply.github.com> Co-authored-by: ulysses78 <andiklamt78@yahoo.de> * Bugfixes: (quasi) angstroem plot Bug Description --------------- No plots of quasi-angstroem exponent after moving to Picasso v3.x. Bug Analysis ------------ Wrong implementation of channel existence check for 1064 total. ``` matlab flag1064 = data.flagFarRangeChannel & data.flag1064nmChannel & data.flagCrossChannel; % before ``` Bug Fixes --------- Fix channel existence check, as below: ``` matlab flag1064 = data.flagFarRangeChannel & data.flag1064nmChannel & data.flagTotalChannel; ``` close #134 * Bugfixes: replace empty/invalid gdas1 data Replace invalid/empty GDAS1 profiles with profiles from standard atmosphere. Close #135 * Bugfixes: correct meteor filter Check for invalid meteorological data in last [commit](3f02c5b) is wrong, as `~ any(isnan(alt))` condition check would filter meteorological profile containing any NaN height level. The idea for this check is to detect profile which is empty, all NaNs or only one unique height level. Therefore, this check was corrected as below, ``` matlab % previous isempty(alt) || (~ any(isnan(alt))) || (length(unique(alt)) < 2) % now isempty(alt) || (~ all(isnan(alt))) || (length(unique(alt)) < 2) ``` associated with #135 * bug fixed of new meteor filter, ~ was wrong * added 1064 nm, saving and displaying still missing, minor spell checking * added saving of 1064s vertical profiles to netcdf. * minor bug fixing, adding saving of 1064 depol products, started visualization of 1064 depol products * added displaying of 1064 depol * added some print_msg, to find out at which postition it takes that long time * final changes for 1064s implementation * bugfixes: minor fixes on 1064 depol * Feat: 1064 depol (beta) - Implement of 1064 depol for pollyxt_cpv - Revise code style of python script - Add prompts for data visualization * bug fix 1064s and shots minor bug fixing for the implementation of the 1064 depol. And changes the storage of shots from int16 to int32, because partly more shots are used. * variable inititalized at different place Co-authored-by: Zhenping Yin <ZP.Yin@whu.edu.cn> Co-authored-by: griesche <48522799+griesche@users.noreply.github.com> Co-authored-by: ulysses78 <andiklamt78@yahoo.de> Co-authored-by: Baymax <test@email.com>
Keep pollynet processing chain running even without housekeeping plot and long-term calibration plot. -> Good extension for simulated data from ALiDAn.
deleted bac files
* Homogenization of variable names for OC (overlap corected) and NR (near-range) files (#133) * Added near-range SNR to pollySaveNRAttnBeta plus older commits (#125) * Bugfixes: add Klett Bsc NR Insert the metadata of Klett Bsc NR figure to the done_filelist. close #116 * Bugfixes: show nr Klett profiles Fix bugs associated with missing near-field profiles with Klett method. Update the version `3.2` to identify this change. Close #116 * Andi branch 01 (#121) * added database param -AutoCommit- and value -off- in var. conn and commited out set(conn,...)-function * added database param -AutoCommit- and value -off- in var. conn and commited out set(conn,...)-function continued * added matlab-version check to correctly set database connection parameters * added variable tilt_angle * replaced function split with function strsplit to get the release-version Co-authored-by: ulysses78 <andiklamt78@yahoo.de> * Added near-range SNR * incorporated requested chagens from pull reqeust Co-authored-by: Zhenping <zp.yin@whu.edu.cn> Co-authored-by: Holger Baars <55800803+HolgerPollyNet@users.noreply.github.com> Co-authored-by: ulysses78 <andiklamt78@yahoo.de> * Added near-range quality mask (#128) * Added near-range quality mask * Added near range quality mask * Added near range quality mask * Dev (#129) * Added near-range quality mask * Added near range quality mask * Added near range quality mask * Changed file name to default name Co-authored-by: griesche <48522799+griesche@users.noreply.github.com> Co-authored-by: Holger Baars <55800803+HolgerPollyNet@users.noreply.github.com> Co-authored-by: ulysses78 <andiklamt78@yahoo.de> * Bugfixes: (quasi) angstroem plot Bug Description --------------- No plots of quasi-angstroem exponent after moving to Picasso v3.x. Bug Analysis ------------ Wrong implementation of channel existence check for 1064 total. ``` matlab flag1064 = data.flagFarRangeChannel & data.flag1064nmChannel & data.flagCrossChannel; % before ``` Bug Fixes --------- Fix channel existence check, as below: ``` matlab flag1064 = data.flagFarRangeChannel & data.flag1064nmChannel & data.flagTotalChannel; ``` close #134 * Bugfixes: replace empty/invalid gdas1 data Replace invalid/empty GDAS1 profiles with profiles from standard atmosphere. Close #135 * Bugfixes: correct meteor filter Check for invalid meteorological data in last [commit](3f02c5b) is wrong, as `~ any(isnan(alt))` condition check would filter meteorological profile containing any NaN height level. The idea for this check is to detect profile which is empty, all NaNs or only one unique height level. Therefore, this check was corrected as below, ``` matlab % previous isempty(alt) || (~ any(isnan(alt))) || (length(unique(alt)) < 2) % now isempty(alt) || (~ all(isnan(alt))) || (length(unique(alt)) < 2) ``` associated with #135 * bug fixed of new meteor filter, ~ was wrong * added 1064 nm, saving and displaying still missing, minor spell checking * added saving of 1064s vertical profiles to netcdf. * minor bug fixing, adding saving of 1064 depol products, started visualization of 1064 depol products * added displaying of 1064 depol * added some print_msg, to find out at which postition it takes that long time * final changes for 1064s implementation * bugfixes: minor fixes on 1064 depol * Feat: 1064 depol (beta) - Implement of 1064 depol for pollyxt_cpv - Revise code style of python script - Add prompts for data visualization * bug fix 1064s and shots minor bug fixing for the implementation of the 1064 depol. And changes the storage of shots from int16 to int32, because partly more shots are used. * variable inititalized at different place * added channel tag for 1064s * added 532p channel again * changed color for 1064 depol * just used dev requirements, no clue if this is correct * bak files deleted deleted bac files * changes in global config to allow for 1064 depol (15 channles) Co-authored-by: Zhenping Yin <ZP.Yin@whu.edu.cn> Co-authored-by: griesche <48522799+griesche@users.noreply.github.com> Co-authored-by: ulysses78 <andiklamt78@yahoo.de> Co-authored-by: Baymax <test@email.com>
T correction did not work
ZPYin
reviewed
Apr 7, 2022
| @@ -398,7 +398,8 @@ | |||
| 'flag407nmChannel', data.flag407nmChannel, ... | |||
| 'flag355nmRotRaman', data.flag355nmChannel & data.flagRotRamanChannel, ... | |||
| 'flag532nmRotRaman', data.flag532nmChannel & data.flagRotRamanChannel, ... | |||
| 'flag1064nmRotRaman', data.flag1064nmChannel & data.flagRotRamanChannel); | |||
| 'flag1064nmRotRaman', data.flag1064nmChannel & data.flagRotRamanChannel, ... | |||
| 'isUseLatestGDAS', PollyConfig.flagUseLatestGDAS); | |||
There was a problem hiding this comment.
should this be flagUseLatestGDAS, according to your relavant fix in pollyPreprocess.m?
Maybe one tip after changing the arguments of function, i.e., input/output/keywords. One should also change the docstring of the function in the headers. It's good for others to use the updated function correctly.
There was a problem hiding this comment.
Actually, I have no clue ;-) The way it is now it is working, but feel free to change it in a way you think it is more consistent....
There was a problem hiding this comment.
I did not want to change line 758, and thus just copied from there....
There was a problem hiding this comment.
Feel free to chnage oit for more consistency
ZPYin
requested changes
Apr 7, 2022
ZPYin
reviewed
Apr 7, 2022
lib/preprocess/pollyPreprocess.m
Outdated
| @@ -295,7 +296,7 @@ | |||
|
|
|||
| syms T | |||
| for iCh = 1:size(data.signal, 1) | |||
| corFunc = sym(config.tempCorFunc{iCh}); | |||
| corFunc = sym(config.tempCorFunc{iCh}); | |||
There was a problem hiding this comment.
btw, did you really make some modifications for temperature correct function? What I see is that they are still identical (before/after your fixes)...
There was a problem hiding this comment.
no, I did not really make changes here.....obviously the encoding again
HolgerPollyNet
commented
Apr 11, 2022
| @@ -195,6 +195,7 @@ | |||
| addParameter(p, 'flag355nmRotRaman', false, @islogical); | |||
| addParameter(p, 'flag532nmRotRaman', false, @islogical); | |||
| addParameter(p, 'flag1064nmRotRaman', false, @islogical); | |||
| addParameter(p, 'flagUseLatestGDAS', false, @islogical); | |||
There was a problem hiding this comment.
this is the only thing I added
small format change
ZPYin
approved these changes
Apr 11, 2022
ZPYin
added a commit
that referenced
this pull request
Apr 14, 2022
* Homogenization of variable names for OC (overlap corected) and NR (near-range) files (#133) * Added near-range SNR to pollySaveNRAttnBeta plus older commits (#125) * Bugfixes: add Klett Bsc NR Insert the metadata of Klett Bsc NR figure to the done_filelist. close #116 * Bugfixes: show nr Klett profiles Fix bugs associated with missing near-field profiles with Klett method. Update the version `3.2` to identify this change. Close #116 * Andi branch 01 (#121) * added database param -AutoCommit- and value -off- in var. conn and commited out set(conn,...)-function * added database param -AutoCommit- and value -off- in var. conn and commited out set(conn,...)-function continued * added matlab-version check to correctly set database connection parameters * added variable tilt_angle * replaced function split with function strsplit to get the release-version Co-authored-by: ulysses78 <andiklamt78@yahoo.de> * Added near-range SNR * incorporated requested chagens from pull reqeust Co-authored-by: Zhenping <zp.yin@whu.edu.cn> Co-authored-by: Holger Baars <55800803+HolgerPollyNet@users.noreply.github.com> Co-authored-by: ulysses78 <andiklamt78@yahoo.de> * Added near-range quality mask (#128) * Added near-range quality mask * Added near range quality mask * Added near range quality mask * Dev (#129) * Added near-range quality mask * Added near range quality mask * Added near range quality mask * Changed file name to default name Co-authored-by: griesche <48522799+griesche@users.noreply.github.com> Co-authored-by: Holger Baars <55800803+HolgerPollyNet@users.noreply.github.com> Co-authored-by: ulysses78 <andiklamt78@yahoo.de> * Bugfixes: (quasi) angstroem plot Bug Description --------------- No plots of quasi-angstroem exponent after moving to Picasso v3.x. Bug Analysis ------------ Wrong implementation of channel existence check for 1064 total. ``` matlab flag1064 = data.flagFarRangeChannel & data.flag1064nmChannel & data.flagCrossChannel; % before ``` Bug Fixes --------- Fix channel existence check, as below: ``` matlab flag1064 = data.flagFarRangeChannel & data.flag1064nmChannel & data.flagTotalChannel; ``` close #134 * Bugfixes: replace empty/invalid gdas1 data Replace invalid/empty GDAS1 profiles with profiles from standard atmosphere. Close #135 * Bugfixes: correct meteor filter Check for invalid meteorological data in last [commit](3f02c5b) is wrong, as `~ any(isnan(alt))` condition check would filter meteorological profile containing any NaN height level. The idea for this check is to detect profile which is empty, all NaNs or only one unique height level. Therefore, this check was corrected as below, ``` matlab % previous isempty(alt) || (~ any(isnan(alt))) || (length(unique(alt)) < 2) % now isempty(alt) || (~ all(isnan(alt))) || (length(unique(alt)) < 2) ``` associated with #135 * bug fixed of new meteor filter, ~ was wrong * changed pollyxt_names from uppercase to lowercase (#144) * Added near-range SNR to pollySaveNRAttnBeta plus older commits (#125) * Bugfixes: add Klett Bsc NR Insert the metadata of Klett Bsc NR figure to the done_filelist. close #116 * Bugfixes: show nr Klett profiles Fix bugs associated with missing near-field profiles with Klett method. Update the version `3.2` to identify this change. Close #116 * Andi branch 01 (#121) * added database param -AutoCommit- and value -off- in var. conn and commited out set(conn,...)-function * added database param -AutoCommit- and value -off- in var. conn and commited out set(conn,...)-function continued * added matlab-version check to correctly set database connection parameters * added variable tilt_angle * replaced function split with function strsplit to get the release-version Co-authored-by: ulysses78 <andiklamt78@yahoo.de> * Added near-range SNR * incorporated requested chagens from pull reqeust Co-authored-by: Zhenping <zp.yin@whu.edu.cn> Co-authored-by: Holger Baars <55800803+HolgerPollyNet@users.noreply.github.com> Co-authored-by: ulysses78 <andiklamt78@yahoo.de> * Added near-range quality mask (#128) * Added near-range quality mask * Added near range quality mask * Added near range quality mask * Dev (#129) * Added near-range quality mask * Added near range quality mask * Added near range quality mask * Changed file name to default name * Implementation of 1064 depol for pollyxt_cpv (#139) * Homogenization of variable names for OC (overlap corected) and NR (near-range) files (#133) * Added near-range SNR to pollySaveNRAttnBeta plus older commits (#125) * Bugfixes: add Klett Bsc NR Insert the metadata of Klett Bsc NR figure to the done_filelist. close #116 * Bugfixes: show nr Klett profiles Fix bugs associated with missing near-field profiles with Klett method. Update the version `3.2` to identify this change. Close #116 * Andi branch 01 (#121) * added database param -AutoCommit- and value -off- in var. conn and commited out set(conn,...)-function * added database param -AutoCommit- and value -off- in var. conn and commited out set(conn,...)-function continued * added matlab-version check to correctly set database connection parameters * added variable tilt_angle * replaced function split with function strsplit to get the release-version Co-authored-by: ulysses78 <andiklamt78@yahoo.de> * Added near-range SNR * incorporated requested chagens from pull reqeust Co-authored-by: Zhenping <zp.yin@whu.edu.cn> Co-authored-by: Holger Baars <55800803+HolgerPollyNet@users.noreply.github.com> Co-authored-by: ulysses78 <andiklamt78@yahoo.de> * Added near-range quality mask (#128) * Added near-range quality mask * Added near range quality mask * Added near range quality mask * Dev (#129) * Added near-range quality mask * Added near range quality mask * Added near range quality mask * Changed file name to default name Co-authored-by: griesche <48522799+griesche@users.noreply.github.com> Co-authored-by: Holger Baars <55800803+HolgerPollyNet@users.noreply.github.com> Co-authored-by: ulysses78 <andiklamt78@yahoo.de> * Bugfixes: (quasi) angstroem plot Bug Description --------------- No plots of quasi-angstroem exponent after moving to Picasso v3.x. Bug Analysis ------------ Wrong implementation of channel existence check for 1064 total. ``` matlab flag1064 = data.flagFarRangeChannel & data.flag1064nmChannel & data.flagCrossChannel; % before ``` Bug Fixes --------- Fix channel existence check, as below: ``` matlab flag1064 = data.flagFarRangeChannel & data.flag1064nmChannel & data.flagTotalChannel; ``` close #134 * Bugfixes: replace empty/invalid gdas1 data Replace invalid/empty GDAS1 profiles with profiles from standard atmosphere. Close #135 * Bugfixes: correct meteor filter Check for invalid meteorological data in last [commit](3f02c5b) is wrong, as `~ any(isnan(alt))` condition check would filter meteorological profile containing any NaN height level. The idea for this check is to detect profile which is empty, all NaNs or only one unique height level. Therefore, this check was corrected as below, ``` matlab % previous isempty(alt) || (~ any(isnan(alt))) || (length(unique(alt)) < 2) % now isempty(alt) || (~ all(isnan(alt))) || (length(unique(alt)) < 2) ``` associated with #135 * bug fixed of new meteor filter, ~ was wrong * added 1064 nm, saving and displaying still missing, minor spell checking * added saving of 1064s vertical profiles to netcdf. * minor bug fixing, adding saving of 1064 depol products, started visualization of 1064 depol products * added displaying of 1064 depol * added some print_msg, to find out at which postition it takes that long time * final changes for 1064s implementation * bugfixes: minor fixes on 1064 depol * Feat: 1064 depol (beta) - Implement of 1064 depol for pollyxt_cpv - Revise code style of python script - Add prompts for data visualization Co-authored-by: griesche <48522799+griesche@users.noreply.github.com> Co-authored-by: Holger Baars <55800803+HolgerPollyNet@users.noreply.github.com> Co-authored-by: ulysses78 <andiklamt78@yahoo.de> Co-authored-by: Baymax <test@email.com> Co-authored-by: Holger Baars <baars@tropos.de> * Minor bug fixes in terms of running 1064 vdr in the server (#140) * Homogenization of variable names for OC (overlap corected) and NR (near-range) files (#133) * Added near-range SNR to pollySaveNRAttnBeta plus older commits (#125) * Bugfixes: add Klett Bsc NR Insert the metadata of Klett Bsc NR figure to the done_filelist. close #116 * Bugfixes: show nr Klett profiles Fix bugs associated with missing near-field profiles with Klett method. Update the version `3.2` to identify this change. Close #116 * Andi branch 01 (#121) * added database param -AutoCommit- and value -off- in var. conn and commited out set(conn,...)-function * added database param -AutoCommit- and value -off- in var. conn and commited out set(conn,...)-function continued * added matlab-version check to correctly set database connection parameters * added variable tilt_angle * replaced function split with function strsplit to get the release-version Co-authored-by: ulysses78 <andiklamt78@yahoo.de> * Added near-range SNR * incorporated requested chagens from pull reqeust Co-authored-by: Zhenping <zp.yin@whu.edu.cn> Co-authored-by: Holger Baars <55800803+HolgerPollyNet@users.noreply.github.com> Co-authored-by: ulysses78 <andiklamt78@yahoo.de> * Added near-range quality mask (#128) * Added near-range quality mask * Added near range quality mask * Added near range quality mask * Dev (#129) * Added near-range quality mask * Added near range quality mask * Added near range quality mask * Changed file name to default name Co-authored-by: griesche <48522799+griesche@users.noreply.github.com> Co-authored-by: Holger Baars <55800803+HolgerPollyNet@users.noreply.github.com> Co-authored-by: ulysses78 <andiklamt78@yahoo.de> * Bugfixes: (quasi) angstroem plot Bug Description --------------- No plots of quasi-angstroem exponent after moving to Picasso v3.x. Bug Analysis ------------ Wrong implementation of channel existence check for 1064 total. ``` matlab flag1064 = data.flagFarRangeChannel & data.flag1064nmChannel & data.flagCrossChannel; % before ``` Bug Fixes --------- Fix channel existence check, as below: ``` matlab flag1064 = data.flagFarRangeChannel & data.flag1064nmChannel & data.flagTotalChannel; ``` close #134 * Bugfixes: replace empty/invalid gdas1 data Replace invalid/empty GDAS1 profiles with profiles from standard atmosphere. Close #135 * Bugfixes: correct meteor filter Check for invalid meteorological data in last [commit](3f02c5b) is wrong, as `~ any(isnan(alt))` condition check would filter meteorological profile containing any NaN height level. The idea for this check is to detect profile which is empty, all NaNs or only one unique height level. Therefore, this check was corrected as below, ``` matlab % previous isempty(alt) || (~ any(isnan(alt))) || (length(unique(alt)) < 2) % now isempty(alt) || (~ all(isnan(alt))) || (length(unique(alt)) < 2) ``` associated with #135 * bug fixed of new meteor filter, ~ was wrong * added 1064 nm, saving and displaying still missing, minor spell checking * added saving of 1064s vertical profiles to netcdf. * minor bug fixing, adding saving of 1064 depol products, started visualization of 1064 depol products * added displaying of 1064 depol * added some print_msg, to find out at which postition it takes that long time * final changes for 1064s implementation * bugfixes: minor fixes on 1064 depol * Feat: 1064 depol (beta) - Implement of 1064 depol for pollyxt_cpv - Revise code style of python script - Add prompts for data visualization * bug fix 1064s and shots minor bug fixing for the implementation of the 1064 depol. And changes the storage of shots from int16 to int32, because partly more shots are used. * variable inititalized at different place Co-authored-by: Zhenping Yin <ZP.Yin@whu.edu.cn> Co-authored-by: griesche <48522799+griesche@users.noreply.github.com> Co-authored-by: ulysses78 <andiklamt78@yahoo.de> Co-authored-by: Baymax <test@email.com> * Refractor: remove backup files * Refractor: cont run w/o housekeeping plot Keep pollynet processing chain running even without housekeeping plot and long-term calibration plot. -> Good extension for simulated data from ALiDAn. * minor changes for bug fixing, rsd2 compliance * Adjust channel tags for 1064s (#141) * Homogenization of variable names for OC (overlap corected) and NR (near-range) files (#133) * Added near-range SNR to pollySaveNRAttnBeta plus older commits (#125) * Bugfixes: add Klett Bsc NR Insert the metadata of Klett Bsc NR figure to the done_filelist. close #116 * Bugfixes: show nr Klett profiles Fix bugs associated with missing near-field profiles with Klett method. Update the version `3.2` to identify this change. Close #116 * Andi branch 01 (#121) * added database param -AutoCommit- and value -off- in var. conn and commited out set(conn,...)-function * added database param -AutoCommit- and value -off- in var. conn and commited out set(conn,...)-function continued * added matlab-version check to correctly set database connection parameters * added variable tilt_angle * replaced function split with function strsplit to get the release-version Co-authored-by: ulysses78 <andiklamt78@yahoo.de> * Added near-range SNR * incorporated requested chagens from pull reqeust Co-authored-by: Zhenping <zp.yin@whu.edu.cn> Co-authored-by: Holger Baars <55800803+HolgerPollyNet@users.noreply.github.com> Co-authored-by: ulysses78 <andiklamt78@yahoo.de> * Added near-range quality mask (#128) * Added near-range quality mask * Added near range quality mask * Added near range quality mask * Dev (#129) * Added near-range quality mask * Added near range quality mask * Added near range quality mask * Changed file name to default name Co-authored-by: griesche <48522799+griesche@users.noreply.github.com> Co-authored-by: Holger Baars <55800803+HolgerPollyNet@users.noreply.github.com> Co-authored-by: ulysses78 <andiklamt78@yahoo.de> * Bugfixes: (quasi) angstroem plot Bug Description --------------- No plots of quasi-angstroem exponent after moving to Picasso v3.x. Bug Analysis ------------ Wrong implementation of channel existence check for 1064 total. ``` matlab flag1064 = data.flagFarRangeChannel & data.flag1064nmChannel & data.flagCrossChannel; % before ``` Bug Fixes --------- Fix channel existence check, as below: ``` matlab flag1064 = data.flagFarRangeChannel & data.flag1064nmChannel & data.flagTotalChannel; ``` close #134 * Bugfixes: replace empty/invalid gdas1 data Replace invalid/empty GDAS1 profiles with profiles from standard atmosphere. Close #135 * Bugfixes: correct meteor filter Check for invalid meteorological data in last [commit](3f02c5b) is wrong, as `~ any(isnan(alt))` condition check would filter meteorological profile containing any NaN height level. The idea for this check is to detect profile which is empty, all NaNs or only one unique height level. Therefore, this check was corrected as below, ``` matlab % previous isempty(alt) || (~ any(isnan(alt))) || (length(unique(alt)) < 2) % now isempty(alt) || (~ all(isnan(alt))) || (length(unique(alt)) < 2) ``` associated with #135 * bug fixed of new meteor filter, ~ was wrong * added 1064 nm, saving and displaying still missing, minor spell checking * added saving of 1064s vertical profiles to netcdf. * minor bug fixing, adding saving of 1064 depol products, started visualization of 1064 depol products * added displaying of 1064 depol * added some print_msg, to find out at which postition it takes that long time * final changes for 1064s implementation * bugfixes: minor fixes on 1064 depol * Feat: 1064 depol (beta) - Implement of 1064 depol for pollyxt_cpv - Revise code style of python script - Add prompts for data visualization * bug fix 1064s and shots minor bug fixing for the implementation of the 1064 depol. And changes the storage of shots from int16 to int32, because partly more shots are used. * variable inititalized at different place * added channel tag for 1064s * added 532p channel again * changed color for 1064 depol * just used dev requirements, no clue if this is correct * bak files deleted deleted bac files * changes in global config to allow for 1064 depol (15 channles) Co-authored-by: Zhenping Yin <ZP.Yin@whu.edu.cn> Co-authored-by: griesche <48522799+griesche@users.noreply.github.com> Co-authored-by: ulysses78 <andiklamt78@yahoo.de> Co-authored-by: Baymax <test@email.com> * Bugfixes: rm negative sig filter Negative signal filter for calculating summed signal at reference height, leads to positive bias of (Raman) backscatter. Therefore, it was removed in this commit. close #143 * changed format from dos to unix * tracked folder \config * changed pollyxt_names from uppercase to lowercase in config/pollynet_processing_chain_config_links.xlsx Co-authored-by: griesche <48522799+griesche@users.noreply.github.com> Co-authored-by: Zhenping <zp.yin@whu.edu.cn> Co-authored-by: Holger Baars <55800803+HolgerPollyNet@users.noreply.github.com> Co-authored-by: Baymax <test@email.com> Co-authored-by: Holger Baars <baars@tropos.de> * Bugfix for Temperature correction (#151) * Added near-range SNR to pollySaveNRAttnBeta plus older commits (#125) * Bugfixes: add Klett Bsc NR Insert the metadata of Klett Bsc NR figure to the done_filelist. close #116 * Bugfixes: show nr Klett profiles Fix bugs associated with missing near-field profiles with Klett method. Update the version `3.2` to identify this change. Close #116 * Andi branch 01 (#121) * added database param -AutoCommit- and value -off- in var. conn and commited out set(conn,...)-function * added database param -AutoCommit- and value -off- in var. conn and commited out set(conn,...)-function continued * added matlab-version check to correctly set database connection parameters * added variable tilt_angle * replaced function split with function strsplit to get the release-version Co-authored-by: ulysses78 <andiklamt78@yahoo.de> * Added near-range SNR * incorporated requested chagens from pull reqeust Co-authored-by: Zhenping <zp.yin@whu.edu.cn> Co-authored-by: Holger Baars <55800803+HolgerPollyNet@users.noreply.github.com> Co-authored-by: ulysses78 <andiklamt78@yahoo.de> * Added near-range quality mask (#128) * Added near-range quality mask * Added near range quality mask * Added near range quality mask * Dev (#129) * Added near-range quality mask * Added near range quality mask * Added near range quality mask * Changed file name to default name * added 1064 nm, saving and displaying still missing, minor spell checking * added saving of 1064s vertical profiles to netcdf. * minor bug fixing, adding saving of 1064 depol products, started visualization of 1064 depol products * added displaying of 1064 depol * added some print_msg, to find out at which postition it takes that long time * final changes for 1064s implementation * bugfixes: minor fixes on 1064 depol * Feat: 1064 depol (beta) - Implement of 1064 depol for pollyxt_cpv - Revise code style of python script - Add prompts for data visualization * Implementation of 1064 depol for pollyxt_cpv (#139) * Homogenization of variable names for OC (overlap corected) and NR (near-range) files (#133) * Added near-range SNR to pollySaveNRAttnBeta plus older commits (#125) * Bugfixes: add Klett Bsc NR Insert the metadata of Klett Bsc NR figure to the done_filelist. close #116 * Bugfixes: show nr Klett profiles Fix bugs associated with missing near-field profiles with Klett method. Update the version `3.2` to identify this change. Close #116 * Andi branch 01 (#121) * added database param -AutoCommit- and value -off- in var. conn and commited out set(conn,...)-function * added database param -AutoCommit- and value -off- in var. conn and commited out set(conn,...)-function continued * added matlab-version check to correctly set database connection parameters * added variable tilt_angle * replaced function split with function strsplit to get the release-version Co-authored-by: ulysses78 <andiklamt78@yahoo.de> * Added near-range SNR * incorporated requested chagens from pull reqeust Co-authored-by: Zhenping <zp.yin@whu.edu.cn> Co-authored-by: Holger Baars <55800803+HolgerPollyNet@users.noreply.github.com> Co-authored-by: ulysses78 <andiklamt78@yahoo.de> * Added near-range quality mask (#128) * Added near-range quality mask * Added near range quality mask * Added near range quality mask * Dev (#129) * Added near-range quality mask * Added near range quality mask * Added near range quality mask * Changed file name to default name Co-authored-by: griesche <48522799+griesche@users.noreply.github.com> Co-authored-by: Holger Baars <55800803+HolgerPollyNet@users.noreply.github.com> Co-authored-by: ulysses78 <andiklamt78@yahoo.de> * Bugfixes: (quasi) angstroem plot Bug Description --------------- No plots of quasi-angstroem exponent after moving to Picasso v3.x. Bug Analysis ------------ Wrong implementation of channel existence check for 1064 total. ``` matlab flag1064 = data.flagFarRangeChannel & data.flag1064nmChannel & data.flagCrossChannel; % before ``` Bug Fixes --------- Fix channel existence check, as below: ``` matlab flag1064 = data.flagFarRangeChannel & data.flag1064nmChannel & data.flagTotalChannel; ``` close #134 * Bugfixes: replace empty/invalid gdas1 data Replace invalid/empty GDAS1 profiles with profiles from standard atmosphere. Close #135 * Bugfixes: correct meteor filter Check for invalid meteorological data in last [commit](3f02c5b) is wrong, as `~ any(isnan(alt))` condition check would filter meteorological profile containing any NaN height level. The idea for this check is to detect profile which is empty, all NaNs or only one unique height level. Therefore, this check was corrected as below, ``` matlab % previous isempty(alt) || (~ any(isnan(alt))) || (length(unique(alt)) < 2) % now isempty(alt) || (~ all(isnan(alt))) || (length(unique(alt)) < 2) ``` associated with #135 * bug fixed of new meteor filter, ~ was wrong * added 1064 nm, saving and displaying still missing, minor spell checking * added saving of 1064s vertical profiles to netcdf. * minor bug fixing, adding saving of 1064 depol products, started visualization of 1064 depol products * added displaying of 1064 depol * added some print_msg, to find out at which postition it takes that long time * final changes for 1064s implementation * bugfixes: minor fixes on 1064 depol * Feat: 1064 depol (beta) - Implement of 1064 depol for pollyxt_cpv - Revise code style of python script - Add prompts for data visualization Co-authored-by: griesche <48522799+griesche@users.noreply.github.com> Co-authored-by: Holger Baars <55800803+HolgerPollyNet@users.noreply.github.com> Co-authored-by: ulysses78 <andiklamt78@yahoo.de> Co-authored-by: Baymax <test@email.com> Co-authored-by: Holger Baars <baars@tropos.de> * bug fix 1064s and shots minor bug fixing for the implementation of the 1064 depol. And changes the storage of shots from int16 to int32, because partly more shots are used. * variable inititalized at different place * Minor bug fixes in terms of running 1064 vdr in the server (#140) * Homogenization of variable names for OC (overlap corected) and NR (near-range) files (#133) * Added near-range SNR to pollySaveNRAttnBeta plus older commits (#125) * Bugfixes: add Klett Bsc NR Insert the metadata of Klett Bsc NR figure to the done_filelist. close #116 * Bugfixes: show nr Klett profiles Fix bugs associated with missing near-field profiles with Klett method. Update the version `3.2` to identify this change. Close #116 * Andi branch 01 (#121) * added database param -AutoCommit- and value -off- in var. conn and commited out set(conn,...)-function * added database param -AutoCommit- and value -off- in var. conn and commited out set(conn,...)-function continued * added matlab-version check to correctly set database connection parameters * added variable tilt_angle * replaced function split with function strsplit to get the release-version Co-authored-by: ulysses78 <andiklamt78@yahoo.de> * Added near-range SNR * incorporated requested chagens from pull reqeust Co-authored-by: Zhenping <zp.yin@whu.edu.cn> Co-authored-by: Holger Baars <55800803+HolgerPollyNet@users.noreply.github.com> Co-authored-by: ulysses78 <andiklamt78@yahoo.de> * Added near-range quality mask (#128) * Added near-range quality mask * Added near range quality mask * Added near range quality mask * Dev (#129) * Added near-range quality mask * Added near range quality mask * Added near range quality mask * Changed file name to default name Co-authored-by: griesche <48522799+griesche@users.noreply.github.com> Co-authored-by: Holger Baars <55800803+HolgerPollyNet@users.noreply.github.com> Co-authored-by: ulysses78 <andiklamt78@yahoo.de> * Bugfixes: (quasi) angstroem plot Bug Description --------------- No plots of quasi-angstroem exponent after moving to Picasso v3.x. Bug Analysis ------------ Wrong implementation of channel existence check for 1064 total. ``` matlab flag1064 = data.flagFarRangeChannel & data.flag1064nmChannel & data.flagCrossChannel; % before ``` Bug Fixes --------- Fix channel existence check, as below: ``` matlab flag1064 = data.flagFarRangeChannel & data.flag1064nmChannel & data.flagTotalChannel; ``` close #134 * Bugfixes: replace empty/invalid gdas1 data Replace invalid/empty GDAS1 profiles with profiles from standard atmosphere. Close #135 * Bugfixes: correct meteor filter Check for invalid meteorological data in last [commit](3f02c5b) is wrong, as `~ any(isnan(alt))` condition check would filter meteorological profile containing any NaN height level. The idea for this check is to detect profile which is empty, all NaNs or only one unique height level. Therefore, this check was corrected as below, ``` matlab % previous isempty(alt) || (~ any(isnan(alt))) || (length(unique(alt)) < 2) % now isempty(alt) || (~ all(isnan(alt))) || (length(unique(alt)) < 2) ``` associated with #135 * bug fixed of new meteor filter, ~ was wrong * added 1064 nm, saving and displaying still missing, minor spell checking * added saving of 1064s vertical profiles to netcdf. * minor bug fixing, adding saving of 1064 depol products, started visualization of 1064 depol products * added displaying of 1064 depol * added some print_msg, to find out at which postition it takes that long time * final changes for 1064s implementation * bugfixes: minor fixes on 1064 depol * Feat: 1064 depol (beta) - Implement of 1064 depol for pollyxt_cpv - Revise code style of python script - Add prompts for data visualization * bug fix 1064s and shots minor bug fixing for the implementation of the 1064 depol. And changes the storage of shots from int16 to int32, because partly more shots are used. * variable inititalized at different place Co-authored-by: Zhenping Yin <ZP.Yin@whu.edu.cn> Co-authored-by: griesche <48522799+griesche@users.noreply.github.com> Co-authored-by: ulysses78 <andiklamt78@yahoo.de> Co-authored-by: Baymax <test@email.com> * Refractor: remove backup files * Refractor: cont run w/o housekeeping plot Keep pollynet processing chain running even without housekeeping plot and long-term calibration plot. -> Good extension for simulated data from ALiDAn. * minor changes for bug fixing, rsd2 compliance * added channel tag for 1064s * added 532p channel again * changed color for 1064 depol * just used dev requirements, no clue if this is correct * bak files deleted deleted bac files * changes in global config to allow for 1064 depol (15 channles) * Adjust channel tags for 1064s (#141) * Homogenization of variable names for OC (overlap corected) and NR (near-range) files (#133) * Added near-range SNR to pollySaveNRAttnBeta plus older commits (#125) * Bugfixes: add Klett Bsc NR Insert the metadata of Klett Bsc NR figure to the done_filelist. close #116 * Bugfixes: show nr Klett profiles Fix bugs associated with missing near-field profiles with Klett method. Update the version `3.2` to identify this change. Close #116 * Andi branch 01 (#121) * added database param -AutoCommit- and value -off- in var. conn and commited out set(conn,...)-function * added database param -AutoCommit- and value -off- in var. conn and commited out set(conn,...)-function continued * added matlab-version check to correctly set database connection parameters * added variable tilt_angle * replaced function split with function strsplit to get the release-version Co-authored-by: ulysses78 <andiklamt78@yahoo.de> * Added near-range SNR * incorporated requested chagens from pull reqeust Co-authored-by: Zhenping <zp.yin@whu.edu.cn> Co-authored-by: Holger Baars <55800803+HolgerPollyNet@users.noreply.github.com> Co-authored-by: ulysses78 <andiklamt78@yahoo.de> * Added near-range quality mask (#128) * Added near-range quality mask * Added near range quality mask * Added near range quality mask * Dev (#129) * Added near-range quality mask * Added near range quality mask * Added near range quality mask * Changed file name to default name Co-authored-by: griesche <48522799+griesche@users.noreply.github.com> Co-authored-by: Holger Baars <55800803+HolgerPollyNet@users.noreply.github.com> Co-authored-by: ulysses78 <andiklamt78@yahoo.de> * Bugfixes: (quasi) angstroem plot Bug Description --------------- No plots of quasi-angstroem exponent after moving to Picasso v3.x. Bug Analysis ------------ Wrong implementation of channel existence check for 1064 total. ``` matlab flag1064 = data.flagFarRangeChannel & data.flag1064nmChannel & data.flagCrossChannel; % before ``` Bug Fixes --------- Fix channel existence check, as below: ``` matlab flag1064 = data.flagFarRangeChannel & data.flag1064nmChannel & data.flagTotalChannel; ``` close #134 * Bugfixes: replace empty/invalid gdas1 data Replace invalid/empty GDAS1 profiles with profiles from standard atmosphere. Close #135 * Bugfixes: correct meteor filter Check for invalid meteorological data in last [commit](3f02c5b) is wrong, as `~ any(isnan(alt))` condition check would filter meteorological profile containing any NaN height level. The idea for this check is to detect profile which is empty, all NaNs or only one unique height level. Therefore, this check was corrected as below, ``` matlab % previous isempty(alt) || (~ any(isnan(alt))) || (length(unique(alt)) < 2) % now isempty(alt) || (~ all(isnan(alt))) || (length(unique(alt)) < 2) ``` associated with #135 * bug fixed of new meteor filter, ~ was wrong * added 1064 nm, saving and displaying still missing, minor spell checking * added saving of 1064s vertical profiles to netcdf. * minor bug fixing, adding saving of 1064 depol products, started visualization of 1064 depol products * added displaying of 1064 depol * added some print_msg, to find out at which postition it takes that long time * final changes for 1064s implementation * bugfixes: minor fixes on 1064 depol * Feat: 1064 depol (beta) - Implement of 1064 depol for pollyxt_cpv - Revise code style of python script - Add prompts for data visualization * bug fix 1064s and shots minor bug fixing for the implementation of the 1064 depol. And changes the storage of shots from int16 to int32, because partly more shots are used. * variable inititalized at different place * added channel tag for 1064s * added 532p channel again * changed color for 1064 depol * just used dev requirements, no clue if this is correct * bak files deleted deleted bac files * changes in global config to allow for 1064 depol (15 channles) Co-authored-by: Zhenping Yin <ZP.Yin@whu.edu.cn> Co-authored-by: griesche <48522799+griesche@users.noreply.github.com> Co-authored-by: ulysses78 <andiklamt78@yahoo.de> Co-authored-by: Baymax <test@email.com> * bug fix for T correction T correction did not work * Update pollyPreprocess.m small format change Co-authored-by: griesche <48522799+griesche@users.noreply.github.com> Co-authored-by: Zhenping <zp.yin@whu.edu.cn> Co-authored-by: ulysses78 <andiklamt78@yahoo.de> Co-authored-by: Baymax <test@email.com> Co-authored-by: Zhenping Yin <ZP.Yin@whu.edu.cn> Co-authored-by: griesche <48522799+griesche@users.noreply.github.com> Co-authored-by: ulysses78 <andiklamt78@yahoo.de> Co-authored-by: Baymax <test@email.com> Co-authored-by: ulysses78 <86650998+ulysses78@users.noreply.github.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bux fix for T correction