Add tensorstore zarr writer #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
JesseMckinzie
commented
Jul 23, 2024
JesseMckinzie
commented
- Add tensorstore zarr writer from bfiocpp
- Add unit test for zarr writer
- Fix potential bug in calculating tile bounds
sameeul
reviewed
Jul 23, 2024
src/bfio/bfio.py
Outdated
Comment on lines
1351
to
1354
| # Ensure end is not out of boudns | ||
| X_tile_end = min(X_tile_end, self._DIMS["X"]) | ||
| Y_tile_end = min(Y_tile_end, self._DIMS["Y"]) | ||
|
|
There was a problem hiding this comment.
For now, do this only when self._backend_name=="tensorstore".
tests/test_write.py
Outdated
Comment on lines
46
to
50
| # def tearDownModule(): | ||
| # """Remove test images""" | ||
|
|
||
| # logger.info("teardown - Removing test images...") | ||
| # shutil.rmtree(TEST_DIR) |
sameeul
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.