Avoid unnecessary heap allocation and copy #181
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like the current implementation of
From<FileHandle> for PathBuf
passes aPath
reference to thePathBuf::from
which results in a new heap allocation from a call toto_os_string()
down the call-stack.Since
From<FileHandle>
consumes theFileHandle
it seems reasonable to consume the memberPathBuf
and return it to the caller without any copies or allocations.