fix: 🐛 use PascalDCase for FeeType enum members

also refactored the `getFees` method in the STR wrapper to take
advantage of the enum

BREAKING CHANGE: `FeeType` members `stLaunchFee` and `tickerRegFee` are now `StLaunchFee`
and `TickerRegFee`

Author: monitz87

src/contract_wrappers/registries/__tests__/security_token_registry_wrapper.test.ts

@@ -879,7 +879,7 @@ describe('SecurityTokenRegistryWrapper', () => {
       // Params and result expected
       const expectedResult = [new BigNumber(10), new BigNumber(10)];
       const mockedParams = {
-        feeType: FeeType.tickerRegFee,
+        feeType: FeeType.TickerRegFee,
       };
       const bytes32 = stringToBytes32('tickerRegFee');
       // Mocked method

src/contract_wrappers/registries/security_token_registry_wrapper.ts

@@ -1133,22 +1133,13 @@ export default class SecurityTokenRegistryWrapper extends ContractWrapper {
    * Returns the usd & poly fee for a particular feetype
    */
   public getFees = async (params: GetFeesParams) => {
-    let feeType = '';
-    switch (params.feeType) {
-      case FeeType.stLaunchFee: {
-        feeType = stringToBytes32('stLaunchFee');
-        break;
-      }
-      case FeeType.tickerRegFee: {
-        feeType = stringToBytes32('tickerRegFee');
-        break;
-      }
-      default: {
-        assert.assert(false, 'Missing fee type');
-        break;
-      }
+    const { feeType } = params;
+    
+    if (![FeeType.StLaunchFee, FeeType.TickerRegFee].includes(feeType)) {
+      assert.assert(false, 'Incorrect fee type');
     }
-    return (await this.contract).getFees.callAsync(feeType);
+    const feeTypeBytes32 = stringToBytes32(params.feeType);    
+    return (await this.contract).getFees.callAsync(feeTypeBytes32);
   };
 
   /**

src/types.ts

@@ -132,8 +132,8 @@ export enum TransferResult {
 }
 
 export enum FeeType {
-  tickerRegFee,
-  stLaunchFee,
+  TickerRegFee = 'tickerRegFee',
+  StLaunchFee = 'stLaunchFee',
 }
 
 export enum Feature {