fix: proper naming for variables within interfaces in the moduleregistry

Author: Victor Wiebe

src/contract_wrappers/registries/__tests__/module_registry_wrapper.test.ts

@@ -58,22 +58,22 @@ describe('ModuleRegistryWrapper', () => {
       // Address expected
       const expectedResult = true;
       const params = {
-        moduleFactory: '0x4444444444444444444444444444444444444444',
-        securityToken: '0x5555555555555555555555555555555555555555',
+        moduleFactoryAddress: '0x4444444444444444444444444444444444444444',
+        securityTokenAddress: '0x5555555555555555555555555555555555555555',
       };
       // Mocked method
       const mockedMethod = mock(MockedCallMethod);
       // Stub the method
       when(mockedContract.isCompatibleModule).thenReturn(instance(mockedMethod));
       // Stub the request
-      when(mockedMethod.callAsync(params.moduleFactory, params.securityToken)).thenResolve(expectedResult);
+      when(mockedMethod.callAsync(params.moduleFactoryAddress, params.securityTokenAddress)).thenResolve(expectedResult);
       // Real call
       const result = await target.isCompatibleModule(params);
       // Result expectation
       expect(result).toBe(expectedResult);
       // Verifications
       verify(mockedContract.isCompatibleModule).once();
-      verify(mockedMethod.callAsync(params.moduleFactory, params.securityToken)).once();
+      verify(mockedMethod.callAsync(params.moduleFactoryAddress, params.securityTokenAddress)).once();
     });
   });
 
@@ -705,9 +705,9 @@ describe('ModuleRegistryWrapper', () => {
       // Real call
       const result = await target.getFactoryDetails(params);
       // Result expectation
-      expect(result.factoryIsVerified).toBe(factoryIsVerified);
-      expect(result.factoryOwnerAddress).toBe(factoryOwnerAddress);
-      expect(result.listSecurityTokens).toBe(listSecurityTokens);
+      expect(result.isVerified).toBe(factoryIsVerified);
+      expect(result.ownerAddress).toBe(factoryOwnerAddress);
+      expect(result.securityTokenAddresses).toBe(listSecurityTokens);
       // Verifications
       verify(mockedContract.getFactoryDetails).once();
       verify(mockedMethod.callAsync(params.factoryAddress)).once();

src/contract_wrappers/registries/module_registry_wrapper.ts

@@ -149,8 +149,8 @@ interface ModuleTypeParams {
 }
 
 interface IsCompatibleModuleParams {
-  moduleFactory: string;
-  securityToken: string;
+  moduleFactoryAddress: string;
+  securityTokenAddress: string;
 }
 
 interface GetFactoryDetailsParams {
@@ -172,9 +172,9 @@ interface TagsByModule {
 }
 
 interface FactoryDetails {
-  factoryIsVerified: boolean;
-  factoryOwnerAddress: string;
-  listSecurityTokens: string[];
+  isVerified: boolean;
+  ownerAddress: string;
+  securityTokenAddresses: string[];
 }
 // // End of return types ////
 
@@ -217,7 +217,7 @@ export default class ModuleRegistryWrapper extends ContractWrapper {
   }
 
   public isCompatibleModule = async (params: IsCompatibleModuleParams): Promise<boolean> => {
-    return (await this.contract).isCompatibleModule.callAsync(params.moduleFactory, params.securityToken);
+    return (await this.contract).isCompatibleModule.callAsync(params.moduleFactoryAddress, params.securityTokenAddress);
   };
 
   public registerModule = async (params: ModuleFactoryParams) => {
@@ -344,9 +344,9 @@ export default class ModuleRegistryWrapper extends ContractWrapper {
   public getFactoryDetails = async (params: GetFactoryDetailsParams) => {
     const result = await (await this.contract).getFactoryDetails.callAsync(params.factoryAddress);
     const typedResult: FactoryDetails = {
-      factoryIsVerified: result[0],
-      factoryOwnerAddress: result[1],
-      listSecurityTokens: result[2],
+      isVerified: result[0],
+      ownerAddress: result[1],
+      securityTokenAddresses: result[2],
     };
     return typedResult;
   };