Skip to content
This repository was archived by the owner on Jul 6, 2022. It is now read-only.

Commit 609c1fa

Browse files
author
Victor Wiebe
committed
fix: 🐛 dividendCheckpoint start and end type to number type
1 parent eef2446 commit 609c1fa

File tree

2 files changed

+11
-10
lines changed

2 files changed

+11
-10
lines changed

src/contract_wrappers/modules/checkpoint/__tests__/dividend_checkpoint_wrapper.test.ts

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ import {
1717
weiToValue,
1818
valueToWei,
1919
numberArrayToBigNumberArray,
20+
numberToBigNumber,
2021
} from '../../../../utils/convert';
2122
import ModuleWrapper from '../../module_wrapper';
2223

@@ -953,8 +954,8 @@ describe('DividendCheckpointWrapper', () => {
953954

954955
const mockedParams = {
955956
dividendIndex,
956-
start: new Date(2030, 1),
957-
end: new Date(2030, 2),
957+
start: 1,
958+
end: 4,
958959
txData: {},
959960
safetyFactor: 10,
960961
};
@@ -967,8 +968,8 @@ describe('DividendCheckpointWrapper', () => {
967968
when(
968969
mockedMethod.sendTransactionAsync(
969970
objectContaining(new BigNumber(mockedParams.dividendIndex)),
970-
objectContaining(dateToBigNumber(mockedParams.start)),
971-
objectContaining(dateToBigNumber(mockedParams.end)),
971+
objectContaining(numberToBigNumber(mockedParams.start)),
972+
objectContaining(numberToBigNumber(mockedParams.end)),
972973
mockedParams.txData,
973974
mockedParams.safetyFactor,
974975
),
@@ -984,8 +985,8 @@ describe('DividendCheckpointWrapper', () => {
984985
verify(
985986
mockedMethod.sendTransactionAsync(
986987
objectContaining(new BigNumber(mockedParams.dividendIndex)),
987-
objectContaining(dateToBigNumber(mockedParams.start)),
988-
objectContaining(dateToBigNumber(mockedParams.end)),
988+
objectContaining(numberToBigNumber(mockedParams.start)),
989+
objectContaining(numberToBigNumber(mockedParams.end)),
989990
mockedParams.txData,
990991
mockedParams.safetyFactor,
991992
),

src/contract_wrappers/modules/checkpoint/dividend_checkpoint_wrapper.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -114,8 +114,8 @@ interface PushDividendPaymentToAddressesParams extends TxParams {
114114
*/
115115
interface PushDividendPaymentParams extends TxParams {
116116
dividendIndex: number;
117-
start: Date;
118-
end: Date;
117+
start: number;
118+
end: number;
119119
}
120120

121121
/**
@@ -400,8 +400,8 @@ export default abstract class DividendCheckpointWrapper extends ModuleWrapper {
400400
await this.checkValidDividend(params.dividendIndex);
401401
return (await this.contract).pushDividendPayment.sendTransactionAsync(
402402
numberToBigNumber(params.dividendIndex),
403-
dateToBigNumber(params.start),
404-
dateToBigNumber(params.end),
403+
numberToBigNumber(params.start),
404+
numberToBigNumber(params.end),
405405
params.txData,
406406
params.safetyFactor,
407407
);

0 commit comments

Comments
 (0)