fix: 🐛 blacklistTM refactoring and abi issues

Author: Victor Wiebe

.eslintrc.js

@@ -21,6 +21,7 @@ module.exports = {
     // Place to specify ESLint rules. Can be used to overwrite rules specified from the extended configs
     // e.g. "@typescript-eslint/explicit-function-return-type": "off",
     '@typescript-eslint/explicit-function-return-type': 'off',
+    "import/prefer-default-export": 'off',
     'jest/expect-expect': 'error',
     'jest/no-empty-title': 'warn',
     'jest/no-truthy-falsy': 'warn',

examples/blacklistTransferManager.ts

@@ -27,7 +27,7 @@ window.addEventListener('load', async () => {
   const tokenName = prompt('Token Name', '');
 
   // Double check available
-  await polymathAPI.securityTokenRegistry.isTickerAvailable({
+  await polymathAPI.securityTokenRegistry.tickerAvailable({
     ticker: ticker!,
   });
   // Get the ticker fee and approve the security token registry to spend

src/PolymathAPI.ts

@@ -4,28 +4,28 @@ import {
   BigNumber,
   providerUtils,
   Provider,
-  PolymathRegistry,
-  ISecurityTokenRegistry,
-  ISecurityToken,
-  PolyToken,
-  ModuleRegistry,
-  CappedSTO,
-  ModuleFactory,
-  USDTieredSTO,
-  FeatureRegistry,
-  GeneralTransferManager,
-  GeneralPermissionManager,
-  ERC20DividendCheckpoint,
-  ManualApprovalTransferManager,
-  CountTransferManager,
-  PercentageTransferManager,
-  LockUpTransferManager,
-  BlacklistTransferManager,
-  EtherDividendCheckpoint,
-  VolumeRestrictionTransferManager,
-  PolyTokenFaucet,
-  Module,
-  ERC20Detailed,
+  BlacklistTransferManagerContract,
+  CappedSTOContract,
+  CountTransferManagerContract,
+  ERC20DetailedContract,
+  ERC20DividendCheckpointContract,
+  EtherDividendCheckpointContract,
+  FeatureRegistryContract,
+  GeneralPermissionManagerContract,
+  GeneralTransferManagerContract,
+  ISecurityTokenContract,
+  ISecurityTokenRegistryContract,
+  LockUpTransferManagerContract,
+  ManualApprovalTransferManagerContract,
+  ModuleContract,
+  ModuleFactoryContract,
+  ModuleRegistryContract,
+  PercentageTransferManagerContract,
+  PolymathRegistryContract,
+  PolyTokenContract,
+  PolyTokenFaucetContract,
+  USDTieredSTOContract,
+  VolumeRestrictionTMContract,
 } from '@polymathnetwork/abi-wrappers';
 import PolymathRegistryWrapper from './contract_wrappers/registries/polymath_registry_wrapper';
 import SecurityTokenRegistryWrapper from './contract_wrappers/registries/security_token_registry_wrapper';

src/contract_wrappers/modules/transfer_manager/blacklist_transfer_manager_wrapper.ts

@@ -1,7 +1,5 @@
 import {
   BigNumber,
-  ContractAbi,
-  BlacklistTransferManager,
   BlacklistTransferManagerContract,
   BlacklistTransferManagerEventArgs,
   BlacklistTransferManagerEvents,
@@ -223,8 +221,6 @@ interface BlacklistsDetails {
  * This class includes the functionality related to interacting with the Blacklist Transfer Manager contract.
  */
 export default class BlacklistTransferManagerWrapper extends ModuleWrapper {
-  public abi: ContractAbi = BlacklistTransferManager.abi;
-
   protected contract: Promise<BlacklistTransferManagerContract>;
 
   /**
@@ -687,11 +683,10 @@ export default class BlacklistTransferManagerWrapper extends ModuleWrapper {
     assert.doesConformToSchema('indexFilterValues', params.indexFilterValues, schemas.indexFilterValuesSchema);
     assert.isFunction('callback', params.callback);
     const normalizedContractAddress = (await this.contract).address.toLowerCase();
-    const subscriptionToken = this.subscribeInternal<ArgsType>(
+    const subscriptionToken = await this.subscribeInternal<ArgsType>(
       normalizedContractAddress,
       params.eventName,
       params.indexFilterValues,
-      BlacklistTransferManager.abi,
       params.callback,
       params.isVerbose,
     );
@@ -716,7 +711,6 @@ export default class BlacklistTransferManagerWrapper extends ModuleWrapper {
       params.eventName,
       params.blockRange,
       params.indexFilterValues,
-      BlacklistTransferManager.abi,
     );
     return logs;
   };