fix: 🐛 assert document exists before removeDocument (ST)

Author: Victor Wiebe

src/contract_wrappers/tokens/__tests__/security_token_wrapper.test.ts

@@ -41,7 +41,8 @@ import {
   weiToValue,
   stringArrayToBytes32Array,
   bytes32ArrayToStringArray,
-  bigNumberToDate, parsePartitionBytes32Value,
+  bigNumberToDate,
+  parsePartitionBytes32Value,
 } from '../../../utils/convert';
 import { MockedCallMethod, MockedSendMethod, getMockedPolyResponse } from '../../../test_utils/mocked_methods';
 
@@ -4838,6 +4839,20 @@ describe('SecurityTokenWrapper', () => {
     test.todo('should fail if name is 0 length');
     test.todo('should fail if uri is 0 length');
     test('should send the transaction to removeDocument', async () => {
+      const documentUri = 'Uri';
+      const documentHash = stringToBytes32('Hash');
+      const documentTime = new Date(2030, 1);
+      const expectedGetDocumentResult = [documentUri, documentHash, dateToBigNumber(documentTime)];
+      // Mocked method
+      const mockedGetDocumentParams = { name: 'Name' };
+      const mockedGetDocumentMethod = mock(MockedCallMethod);
+      // Stub the method
+      when(mockedContract.getDocument).thenReturn(instance(mockedGetDocumentMethod));
+      // Stub the request
+      when(
+        mockedGetDocumentMethod.callAsync(objectContaining(stringToBytes32(mockedGetDocumentParams.name))),
+      ).thenResolve(expectedGetDocumentResult);
+
       // Mocked parameters
       const mockedParams = {
         name: 'Name',
@@ -4887,6 +4902,8 @@ describe('SecurityTokenWrapper', () => {
       verify(mockedContract.owner).once();
       verify(mockedOwnerMethod.callAsync()).once();
       verify(mockedWrapper.getAvailableAddressesAsync()).once();
+      verify(mockedContract.getDocument).once();
+      verify(mockedGetDocumentMethod.callAsync(objectContaining(stringToBytes32(mockedGetDocumentParams.name)))).once();
     });
   });
 

src/contract_wrappers/tokens/security_token_wrapper.ts

@@ -1615,8 +1615,8 @@ export default class SecurityTokenWrapper extends ERC20TokenWrapper {
   };
 
   public setDocument = async (params: SetDocumentParams) => {
-    assert.assert(params.name.length > 0, 'Bad name');
-    assert.assert(params.uri.length > 0, 'Bad uri');
+    assert.assert(params.name.length > 0, 'Bad name, cannot be empty');
+    assert.assert(params.uri.length > 0, 'Bad uri, cannot be empty');
     await this.checkOnlyOwner(params.txData);
     return (await this.contract).setDocument.sendTransactionAsync(
       stringToBytes32(params.name),
@@ -1629,6 +1629,8 @@ export default class SecurityTokenWrapper extends ERC20TokenWrapper {
 
   public removeDocument = async (params: DocumentParams) => {
     await this.checkOnlyOwner(params.txData);
+    const document = await this.getDocument({name: params.name});
+    assert.assert(document.documentUri.length !== 0, 'Document does not exist');
     return (await this.contract).removeDocument.sendTransactionAsync(
       stringToBytes32(params.name),
       params.txData,