fix: 🐛 fix typo errors requested by feedback

Author: shuffledex

src/contract_wrappers/modules/permission_manager/general_permission_manager_wrapper.ts

@@ -170,7 +170,7 @@ export default class GeneralPermissionManagerWrapper extends ModuleWrapper {
     assert.assert(params.details.length > 0, ErrorCode.InvalidData, '0 value not allowed');
     assert.assert(
       !(await (await this.contract).checkDelegate.callAsync(params.delegate)),
-      ErrorCode.PreconditionRequired,
+      ErrorCode.AlreadyExists,
       'Delegate already present',
     );
     return (await this.contract).addDelegate.sendTransactionAsync(

src/contract_wrappers/modules/transfer_manager/blacklist_transfer_manager_wrapper.ts

@@ -879,7 +879,7 @@ export default class BlacklistTransferManagerWrapper extends ModuleWrapper {
     const currentBlacklistNames = await this.getBlacklistNamesToUser({ user: params.userAddress });
     assert.assert(
       currentBlacklistNames.includes(params.blacklistName),
-      ErrorCode.PreconditionRequired,
+      ErrorCode.NotFound,
       'User is not added to this blacklist name',
     );
   };
@@ -889,7 +889,7 @@ export default class BlacklistTransferManagerWrapper extends ModuleWrapper {
     const currentBlacklistNames = await this.getBlacklistNamesToUser({ user: params.investor });
     assert.assert(
       currentBlacklistNames.length > 0,
-      ErrorCode.PreconditionRequired,
+      ErrorCode.NotFound,
       'Investor is not currently present on any blacklists',
     );
   };

src/contract_wrappers/modules/transfer_manager/manual_approval_transfer_manager_wrapper.ts

@@ -300,7 +300,7 @@ export default class ManualApprovalTransferManagerWrapper extends ModuleWrapper
         params.from.length === params.expiryTimes.length &&
         params.from.length === params.descriptions.length,
       ErrorCode.MismatchedArrayLength,
-      'Array lengths missmatch',
+      'Array lengths mismatch',
     );
     params.expiryTimes.forEach(expiry => assert.isFutureDate(expiry, 'ExpiryTime must be in the future'));
     params.allowances.forEach(allowance =>
@@ -360,7 +360,7 @@ export default class ManualApprovalTransferManagerWrapper extends ModuleWrapper
         params.from.length === params.expiryTimes.length &&
         params.from.length === params.descriptions.length,
       ErrorCode.MismatchedArrayLength,
-      'Array lengths missmatch',
+      'Array lengths mismatch',
     );
     params.expiryTimes.forEach(expiry => assert.isFutureDate(expiry, 'ExpiryTime must be in the future'));
     const approvals = [];
@@ -408,7 +408,7 @@ export default class ManualApprovalTransferManagerWrapper extends ModuleWrapper
     params.to.forEach(address => assert.isETHAddressHex('to', address));
     assert.assert(
       params.to.length === params.from.length,
-      ErrorCode.MismatchedLength,
+      ErrorCode.MismatchedArrayLength,
       'To and From address arrays must have the same length',
     );
     const approvals = [];

src/contract_wrappers/modules/transfer_manager/volume_restriction_transfer_manager_wrapper.ts

@@ -539,7 +539,7 @@ export default class VolumeRestrictionTransferManagerWrapper extends ModuleWrapp
         params.startTimes.length === params.holders.length &&
         params.startTimes.length === params.endTimes.length,
       ErrorCode.MismatchedArrayLength,
-      'Array lengths missmatch',
+      'Array lengths mismatch',
     );
     let restrictions = [];
     for (let i = 0; i < params.startTimes.length; i += 1) {
@@ -588,7 +588,7 @@ export default class VolumeRestrictionTransferManagerWrapper extends ModuleWrapp
         params.startTimes.length === params.holders.length &&
         params.startTimes.length === params.endTimes.length,
       ErrorCode.MismatchedArrayLength,
-      'Array lengths missmatch',
+      'Array lengths mismatch',
     );
     let restrictions = [];
     for (let i = 0; i < params.startTimes.length; i += 1) {
@@ -824,7 +824,7 @@ export default class VolumeRestrictionTransferManagerWrapper extends ModuleWrapp
         params.startTimes.length === params.holders.length &&
         params.startTimes.length === params.endTimes.length,
       ErrorCode.MismatchedArrayLength,
-      'Array lengths missmatch',
+      'Array lengths mismatch',
     );
     let restrictions = [];
     for (let i = 0; i < params.startTimes.length; i += 1) {
@@ -867,7 +867,7 @@ export default class VolumeRestrictionTransferManagerWrapper extends ModuleWrapp
         params.startTimes.length === params.holders.length &&
         params.startTimes.length === params.endTimes.length,
       ErrorCode.MismatchedArrayLength,
-      'Array lengths missmatch',
+      'Array lengths mismatch',
     );
     let restrictions = [];
     for (let i = 0; i < params.startTimes.length; i += 1) {

src/contract_wrappers/registries/module_registry_wrapper.ts

@@ -244,7 +244,7 @@ export default class ModuleRegistryWrapper extends ContractWrapper {
     if (getTypesResult.length > 1) {
       assert.assert(
         getTypesResult.length === new Set(getTypesResult).size,
-        ErrorCode.MismatchedLength,
+        ErrorCode.MismatchedArrayLength,
         'Type mismatch',
       );
     }

src/contract_wrappers/tokens/security_token_wrapper.ts

@@ -1271,7 +1271,7 @@ export default class SecurityTokenWrapper extends ERC20TokenWrapper {
     params.investors.forEach(address => assert.isNonZeroETHAddressHex('investors', address));
     assert.assert(
       params.investors.length === params.values.length,
-      ErrorCode.MismatchedLength,
+      ErrorCode.MismatchedArrayLength,
       'Number of investors passed in must be equivalent to number of values',
     );
     assert.assert(await this.isIssuable(), ErrorCode.PreconditionRequired, 'Issuance frozen');

src/types.ts

@@ -364,7 +364,6 @@ export enum ErrorCode {
   CoinNotAllowed = 'CoinNotAllowed',
   AlreadyExists = 'AlreadyExists',
   NotFound = 'NotFound',
-  MismatchedLength = 'MismatchedLength',
   TickerExpired = 'TickerExpired',
   UnknownNetwork = 'UnknownNetwork',
 }