fix: 🐛 _modifyTicker assertions missing for existing ticker st

Author: Victor Wiebe

src/contract_wrappers/registries/__tests__/security_token_registry_wrapper.test.ts

@@ -695,6 +695,13 @@ describe('SecurityTokenRegistryWrapper', () => {
         txData: {},
         safetyFactor: 10,
       };
+      const securityToken = '0x9999999999999999999999999999999999999999';
+      // Mocked method
+      const mockedGetSecurityTokenAddressMethod = mock(MockedCallMethod);
+      // Stub the method
+      when(mockedContract.getSecurityTokenAddress).thenReturn(instance(mockedGetSecurityTokenAddressMethod));
+      // Stub the request
+      when(mockedGetSecurityTokenAddressMethod.callAsync(mockedParams.ticker)).thenResolve(securityToken);
 
       // checkOnlyOwner
       const expectedOwnerResult = '0x0123456789012345678901234567890123456789';
@@ -739,21 +746,32 @@ describe('SecurityTokenRegistryWrapper', () => {
       verify(mockedContract.owner).once();
       verify(mockedOwnerMethod.callAsync()).once();
       verify(mockedWrapper.getAvailableAddressesAsync()).once();
+      verify(mockedContract.getSecurityTokenAddress).once();
+      verify(mockedGetSecurityTokenAddressMethod.callAsync(mockedParams.ticker)).once();
+
     });
   });
 
   describe('ModifyExistingSecurityToken', () => {
     test('should call modifyExistingSecurityToken with ModifyExistingSecurityTokenParams', async () => {
+      const securityToken= '0x5555555555555555555555555555555555555555';
       const mockedParams = {
         ticker: "TTEST",
         owner: "0x0023456789002345678900234567890023456789",
-        securityToken: "0x1123456789112345678911234567891123456789",
+        securityToken,
         tokenDetails: "",
         deployedAt: new Date(2018, 10, 10),
         txData: {},
         safetyFactor: 10,
       };
 
+      // Mocked method
+      const mockedGetSecurityTokenAddressMethod = mock(MockedCallMethod);
+      // Stub the method
+      when(mockedContract.getSecurityTokenAddress).thenReturn(instance(mockedGetSecurityTokenAddressMethod));
+      // Stub the request
+      when(mockedGetSecurityTokenAddressMethod.callAsync(mockedParams.ticker)).thenResolve(securityToken);
+
       // checkOnlyOwner
       const expectedOwnerResult = '0x0123456789012345678901234567890123456789';
       const mockedOwnerMethod = mock(MockedCallMethod);
@@ -797,6 +815,8 @@ describe('SecurityTokenRegistryWrapper', () => {
       verify(mockedContract.owner).once();
       verify(mockedOwnerMethod.callAsync()).once();
       verify(mockedWrapper.getAvailableAddressesAsync()).once();
+      verify(mockedContract.getSecurityTokenAddress).once();
+      verify(mockedGetSecurityTokenAddressMethod.callAsync(mockedParams.ticker)).once();
     });
   });
 
@@ -2000,6 +2020,13 @@ describe('SecurityTokenRegistryWrapper', () => {
         safetyFactor: 10,
       };
 
+      // Mocked method
+      const mockedGetSecurityTokenAddressMethod = mock(MockedCallMethod);
+      // Stub the method
+      when(mockedContract.getSecurityTokenAddress).thenReturn(instance(mockedGetSecurityTokenAddressMethod));
+      // Stub the request
+      when(mockedGetSecurityTokenAddressMethod.callAsync(mockedParams.ticker)).thenResolve(securityToken);
+
       const expectedResult = getMockedPolyResponse();
       // Mocked method
       const mockedMethod = mock(MockedSendMethod);
@@ -2042,6 +2069,8 @@ describe('SecurityTokenRegistryWrapper', () => {
       verify(mockedContract.owner).once();
       verify(mockedOwnerMethod.callAsync()).once();
       verify(mockedWrapper.getAvailableAddressesAsync()).once();
+      verify(mockedContract.getSecurityTokenAddress).once();
+      verify(mockedGetSecurityTokenAddressMethod.callAsync(mockedParams.ticker)).once();
     });
   });
 

src/contract_wrappers/registries/security_token_registry_wrapper.ts

@@ -747,6 +747,10 @@ export default class SecurityTokenRegistryWrapper extends ContractWrapper {
     assert.assert(params.expiryDate.getTime() > new Date(0).getTime(), 'Bad expiry date');
     assert.assert(params.registrationDate.getTime() > new Date(0).getTime(), 'Bad registration date');
     assert.isNonZeroETHAddressHex('owner', params.owner);
+    if (params.status) {
+      const address = await this.getSecurityTokenAddress(params.ticker);
+      assert.isNonZeroETHAddressHex('address', address);
+    }
     return (await this.contract).modifyExistingTicker.sendTransactionAsync(
       params.owner,
       params.ticker,
@@ -766,6 +770,8 @@ export default class SecurityTokenRegistryWrapper extends ContractWrapper {
     assert.assert(params.ticker.length > 0 && params.ticker.length <= 10, 'Bad ticker');
     assert.assert(params.deployedAt.getTime() > new Date(0).getTime(), 'Bad deployed date');
     assert.isNonZeroETHAddressHex('owner', params.owner);
+    assert.isNonZeroETHAddressHex('Security token not registered for ticker',
+        await this.getSecurityTokenAddress(params.ticker));
     return (await this.contract).modifyExistingSecurityToken.sendTransactionAsync(
       params.ticker,
       params.owner,
@@ -979,6 +985,8 @@ export default class SecurityTokenRegistryWrapper extends ContractWrapper {
     assert.assert(params.ticker.length <= 10, 'Ticker length can not be greater than 10');
     assert.isNonZeroETHAddressHex('owner', params.owner);
     assert.isNonZeroETHAddressHex('securityToken', params.securityToken);
+    assert.isNonZeroETHAddressHex('Security token not registered for ticker',
+        await this.getSecurityTokenAddress(params.ticker));
     return (await this.contract).modifySecurityToken.sendTransactionAsync(
       params.name,
       params.ticker,