fix: remove duplicated methods from erc20Detailed included in erc20

Author: Victor Wiebe

src/contract_wrappers/tokens/__tests__/erc20_detailed_wrapper.test.ts

@@ -1,11 +1,9 @@
 // PolymathRegistryWrapper test
-import { mock, instance, reset, when, verify } from 'ts-mockito';
+import { mock, instance, reset } from 'ts-mockito';
 import { Web3Wrapper } from '@0x/web3-wrapper';
 import { ERC20DetailedContract, SecurityTokenRegistryEvents } from '@polymathnetwork/abi-wrappers';
-import { BigNumber } from '@0x/utils';
 import ERC20TokenWrapper from '../erc20_wrapper';
 import ERC20DetailedTokenWrapper from '../erc20_detailed_wrapper';
-import { MockedCallMethod } from '../../../test_utils/mocked_methods';
 
 describe('ERC20DetailedTokenWrapper', () => {
   // Declare ERC20DetailedTokenWrapper object
@@ -32,73 +30,6 @@ describe('ERC20DetailedTokenWrapper', () => {
     });
   });
 
-  describe('name', () => {
-    test('should call to name', async () => {
-      const expectedResult = 'string';
-      // Mocked method
-      const mockedMethod = mock(MockedCallMethod);
-      // Stub the method
-      when(mockedContract.name).thenReturn(instance(mockedMethod));
-      // Stub the request
-      when(mockedMethod.callAsync()).thenResolve(expectedResult);
-
-      // Real call
-      const result = await target.name();
-      // Result expectation
-      expect(result).toBe(expectedResult);
-      // Verifications
-      verify(mockedContract.name).once();
-      verify(mockedMethod.callAsync()).once();
-    });
-  });
-
-  describe('symbol', () => {
-    test('should call to symbol', async () => {
-      const expectedResult = 'string';
-      // Mocked method
-      const mockedMethod = mock(MockedCallMethod);
-      // Stub the method
-      when(mockedContract.symbol).thenReturn(instance(mockedMethod));
-      // Stub the request
-      when(mockedMethod.callAsync()).thenResolve(expectedResult);
-
-      // Real call
-      const result = await target.symbol();
-      // Result expectation
-      expect(result).toBe(expectedResult);
-      // Verifications
-      verify(mockedContract.symbol).once();
-      verify(mockedMethod.callAsync()).once();
-    });
-  });
-
-  describe('isValidContract', () => {
-    test('should call to isValidContract', async () => {
-      const expectedBNResult = new BigNumber(1);
-      const expectedStringResult = 'string';
-
-      const mockedTotalSupplyMethod = mock(MockedCallMethod);
-      when(mockedContract.totalSupply).thenReturn(instance(mockedTotalSupplyMethod));
-      when(mockedTotalSupplyMethod.callAsync()).thenResolve(expectedBNResult);
-
-      const mockedSymbolMethod = mock(MockedCallMethod);
-      when(mockedContract.symbol).thenReturn(instance(mockedSymbolMethod));
-      when(mockedSymbolMethod.callAsync()).thenResolve(expectedStringResult);
-
-      const mockedNameMethod = mock(MockedCallMethod);
-      when(mockedContract.name).thenReturn(instance(mockedNameMethod));
-      when(mockedSymbolMethod.callAsync()).thenResolve(expectedStringResult);
-
-      const expectedIsValidResult = true;
-      const result = await target.isValidContract();
-      expect(result).toBe(expectedIsValidResult);
-
-      verify(mockedContract.totalSupply).once();
-      verify(mockedContract.symbol).once();
-      verify(mockedContract.name).once();
-    });
-  });
-
   describe('SubscribeAsync', () => {
     test('should throw as eventName does not belong to SecurityTokenRegistryEvents', async () => {
       // Mocked parameters

src/contract_wrappers/tokens/erc20_detailed_wrapper.ts

@@ -29,35 +29,6 @@ export default class ERC20DetailedWrapper extends ERC20TokenWrapper {
     this.contract = contract;
   }
 
-  /**
-   * Returns the token name
-   */
-  public name = async () => {
-    return (await this.contract).name.callAsync();
-  };
-
-  /**
-   * Returns the token symbol
-   */
-  public symbol = async () => {
-    return (await this.contract).symbol.callAsync();
-  };
-
-  public async isValidContract() {
-    try {
-      const contract = await this.contract;
-      const totalSupply = await contract.totalSupply.callAsync();
-      const symbol = await contract.symbol.callAsync();
-      const name = await contract.name.callAsync();
-      if (symbol === '' || name === '' || totalSupply.isZero()) {
-        return false;
-      }
-      return true;
-    } catch (error) {
-      return false;
-    }
-  }
-
   public subscribeAsync: Subscribe = async <ArgsType extends ERC20DetailedEventArgs>(
     params: SubscribeAsyncParams,
   ): Promise<string> => {