Skip to content
This repository was archived by the owner on Jul 6, 2022. It is now read-only.

Commit f691e62

Browse files
author
Victor Wiebe
committed
fix: 🐛 PR fixes across the project
1 parent 609c1fa commit f691e62

File tree

5 files changed

+23
-55
lines changed

5 files changed

+23
-55
lines changed

src/contract_wrappers/modules/checkpoint/dividend_checkpoint_wrapper.ts

Lines changed: 7 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -513,12 +513,8 @@ export default abstract class DividendCheckpointWrapper extends ModuleWrapper {
513513

514514
/**
515515
* Get static dividend data
516-
* @return timestamp of dividends creation
517-
* @return timestamp of dividends maturity
518-
* @return timestamp of dividends expiry
519-
* @return amount of dividends
520-
* @return claimed amount of dividends
521-
* @return name of dividends
516+
* @return timestamp of dividends creation, timestamp of dividends maturity, timestamp of dividends expiry, amount
517+
* of dividends, claimed amount of dividends, name of dividends
522518
*/
523519
public getDividendsData = async () => {
524520
const result = await (await this.contract).getDividendsData.callAsync();
@@ -546,12 +542,8 @@ export default abstract class DividendCheckpointWrapper extends ModuleWrapper {
546542

547543
/**
548544
* Get static dividend data
549-
* @return timestamp of dividend creation
550-
* @return timestamp of dividend maturity
551-
* @return timestamp of dividend expiry
552-
* @return amount of dividend
553-
* @return claimed amount of dividend
554-
* @return name of dividend
545+
* @return timestamp of dividend creation, timestamp of dividend maturity, timestamp of dividend expiry, amount of
546+
* dividend, claimed amount of dividend, name of dividend
555547
*/
556548
public getDividendData = async (params: DividendIndexParams) => {
557549
const decimals = await (await this.securityTokenContract()).decimals.callAsync();
@@ -569,12 +561,8 @@ export default abstract class DividendCheckpointWrapper extends ModuleWrapper {
569561

570562
/**
571563
* Retrieves list of investors, their claim status and whether they are excluded
572-
* @return list of investors
573-
* @return whether investor has claimed
574-
* @return whether investor is excluded
575-
* @return amount of withheld tax (estimate if not claimed)
576-
* @return amount of claim (estimate if not claimeed)
577-
* @return investor balance
564+
* @return list of investors, whether investor has claimed, whether investor is excluded, amount of withheld tax
565+
* (estimate if not claimed), amount of claim (estimate if not claimeed), investor balance
578566
*/
579567
public getDividendProgress = async (params: DividendIndexParams) => {
580568
assert.assert(await this.isValidDividendIndex(params.dividendIndex), 'Invalid dividend index');
@@ -604,9 +592,7 @@ export default abstract class DividendCheckpointWrapper extends ModuleWrapper {
604592

605593
/**
606594
* Retrieves list of investors, their balances, and their current withholding tax percentage
607-
* @return list of investors
608-
* @return investor balances
609-
* @return investor withheld percentages
595+
* @return list of investors, investor balances, investor withheld percentages
610596
*/
611597
public getCheckpointData = async (params: CheckpointIdParams): Promise<CheckpointData[]> => {
612598
const currentCheckpointId = await (await this.securityTokenContract()).currentCheckpointId.callAsync();

src/contract_wrappers/modules/checkpoint/erc20_dividend_checkpoint_wrapper.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -156,7 +156,7 @@ interface CreateDividendParams extends TxParams {
156156
}
157157

158158
/**
159-
* @param _checkpointId Checkpoint id from which to create dividends
159+
* @param checkpointId Checkpoint id from which to create dividends
160160
*/
161161
interface CreateDividendWithCheckpointParams extends CreateDividendParams {
162162
checkpointId: number;

src/contract_wrappers/modules/permission_manager/general_permission_manager_wrapper.ts

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -219,8 +219,6 @@ export default class GeneralPermissionManagerWrapper extends ModuleWrapper {
219219

220220
/**
221221
* Used to add a delegate
222-
* @param delegate Ethereum address of the delegate
223-
* @param details Details about the delegate i.e `Belongs to financial firm`
224222
*/
225223
public addDelegate = async (params: AddDelegateParams) => {
226224
assert.assert(await this.isCallerAllowed(params.txData, Perm.Admin), 'Caller is not allowed');
@@ -306,8 +304,8 @@ export default class GeneralPermissionManagerWrapper extends ModuleWrapper {
306304

307305
/**
308306
* Used to return all permission of a single or multiple module
309-
* @return address[] the address array of Modules this delegate has permission
310-
* @return bytes32[] the permission array of the corresponding Modules
307+
* @return address[] the address array of Modules this delegate has permission, bytes32[]
308+
* the permission array of the corresponding Modules
311309
*/
312310
public getAllModulesAndPermsFromTypes = async (
313311
params: GetAllModulesAndPermsFromTypesParams,

src/contract_wrappers/modules/sto/capped_sto_wrapper.ts

Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -301,15 +301,11 @@ export default class CappedSTOWrapper extends STOWrapper {
301301

302302
/**
303303
* Return the STO details
304-
* @return Date at which offering gets start.
305-
* @return Date at which offering ends.
306-
* @return Number of token base units this STO will be allowed to sell to investors.
307-
* @return Token units a buyer gets as the rate
308-
* @return Amount of funds raised
309-
* @return Number of individual investors this STO have.
310-
* @return Amount of tokens get sold.
311-
* @return Boolean value to justify whether the fund raise type is POLY or not, i.e true for POLY.
312-
* @return Boolean value to know the nature of the STO Whether it is pre-mint or mint on buying type sto.
304+
* @return Date at which offering gets start., Date at which offering ends., Number of token base units this STO will
305+
* be allowed to sell to investors., Token units a buyer gets as the rate, Amount of funds raised, Number of
306+
* individual investors this STO have., Amount of tokens get sold., Boolean value to justify whether the fund raise
307+
* type is POLY or not, i.e true for POLY., Boolean value to know the nature of the STO Whether it is pre-mint or
308+
* mint on buying type sto.
313309
*/
314310
public getSTODetails = async (): Promise<CappedSTODetails> => {
315311
const decimals = await (await this.securityTokenContract()).decimals.callAsync();

src/contract_wrappers/modules/sto/usd_tiered_sto_wrapper.ts

Lines changed: 8 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -221,7 +221,7 @@ export namespace USDTieredSTOTransactionParams {
221221
}
222222

223223
/**
224-
* tier Index of Tier
224+
* @param tier Index of Tier
225225
*/
226226
interface TierIndexParams {
227227
tier: number;
@@ -484,7 +484,7 @@ export default class USDTieredSTOWrapper extends STOWrapper {
484484
};
485485

486486
/**
487-
* check if the module is paused
487+
* Check if the module is paused
488488
* @return boolean if paused
489489
*/
490490
public paused = async (): Promise<boolean> => {
@@ -734,15 +734,10 @@ export default class USDTieredSTOWrapper extends STOWrapper {
734734

735735
/**
736736
* Return the STO details
737-
* @return Unixtimestamp at which offering gets start.
738-
* @return Unixtimestamp at which offering ends.
739-
* @return Currently active tier
740-
* @return Array of Number of tokens this STO will be allowed to sell at different tiers.
741-
* @return Array rate at which tokens are sold at different tiers
742-
* @return Amount of funds raised
743-
* @return Number of individual investors this STO have.
744-
* @return Amount of tokens sold.
745-
* @return Array of booleans to show if funding is allowed in ETH, POLY, SC respectively
737+
* @return Unixtimestamp at which offering gets start., Unixtimestamp at which offering ends., Currently active tier,
738+
* Array of Number of tokens this STO will be allowed to sell at different tiers., Array rate at which tokens are
739+
* sold at different tiers, Amount of funds raised, Number of individual investors this STO have., Amount of tokens
740+
* sold., Array of booleans to show if funding is allowed in ETH, POLY, SC respectively
746741
*/
747742
public getSTODetails = async (): Promise<USDTieredSTOData> => {
748743
const result = await (await this.contract).getSTODetails.callAsync();
@@ -840,12 +835,7 @@ export default class USDTieredSTOWrapper extends STOWrapper {
840835

841836
/**
842837
* Return tiers
843-
* @return rate
844-
* @return rateDiscountPoly
845-
* @return tokensTotal
846-
* @return tokensDiscountPoly
847-
* @return mintedTotal
848-
* @return mintedDiscountPoly
838+
* @return rate, rateDiscountPoly, tokensTotal, tokensDiscountPoly, mintedTotal, mintedDiscountPoly
849839
*/
850840
public tiers = async (params: TierIndexParams): Promise<Tier> => {
851841
const decimals = await (await this.securityTokenContract()).decimals.callAsync();
@@ -1049,9 +1039,7 @@ export default class USDTieredSTOWrapper extends STOWrapper {
10491039

10501040
/**
10511041
* Returns investor accredited & non-accredited override information
1052-
* @return investor[]
1053-
* @return accredited data value
1054-
* @return nonAccreditedLimitUSDOverride value
1042+
* @return investor[], accredited data value, nonAccreditedLimitUSDOverride value
10551043
*/
10561044
public getAccreditedData = async (): Promise<AccreditedData[]> => {
10571045
const result = await (await this.contract).getAccreditedData.callAsync();

0 commit comments

Comments
 (0)