fix: review comments, unnecessary code and internal func

PolymathNetwork · Jan 6, 2020 · 07ad557 · 07ad557
1 parent ce409eb
commit 07ad557
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 14 deletions.
diff --git a/src/procedures/FinalizeSto.ts b/src/procedures/FinalizeSto.ts
@@ -75,12 +75,7 @@ export class FinalizeSto extends Procedure<FinalizeStoProcedureArgs> {
       });
     }
 
-    function throwStoModuleError() {
-      throw new PolymathError({
-        code: ErrorCode.ProcedureValidationError,
-        message: `STO ${stoAddress} is either archived or hasn't been launched`,
-      });
-    }
+    const stoModuleErrorMessage = `STO ${stoAddress} is either archived or hasn't been launched`;
 
     let stoModule;
     let remainingTokens: BigNumber;
@@ -93,7 +88,10 @@ export class FinalizeSto extends Procedure<FinalizeStoProcedureArgs> {
         });
 
         if (!stoModule) {
-          throwStoModuleError();
+          throw new PolymathError({
+            code: ErrorCode.ProcedureValidationError,
+            message: stoModuleErrorMessage,
+          });
         }
 
         if (isCappedSTO_3_0_0(stoModule)) {
@@ -116,7 +114,10 @@ export class FinalizeSto extends Procedure<FinalizeStoProcedureArgs> {
         });
 
         if (!stoModule) {
-          throwStoModuleError();
+          throw new PolymathError({
+            code: ErrorCode.ProcedureValidationError,
+            message: stoModuleErrorMessage,
+          });
         }
 
         const { tokensSold, capPerTier } = await stoModule.getSTODetails();

diff --git a/src/procedures/__tests__/InvestInSimpleSto.ts b/src/procedures/__tests__/InvestInSimpleSto.ts
@@ -154,8 +154,6 @@ describe('InvestInSimpleSto', () => {
       const addProcedureSpy = spy(target, 'addProcedure');
       simpleStoMock.mock('buyTokensWithPoly', Promise.resolve('BuyTokensWithPoly'));
 
-      securityTokenMock.mock('balanceOf', Promise.resolve(new BigNumber(10)));
-
       // Real call
       await target.prepareTransactions();
 

diff --git a/src/procedures/__tests__/InvestInTieredSto.ts b/src/procedures/__tests__/InvestInTieredSto.ts
@@ -162,8 +162,6 @@ describe('InvestInTieredSto', () => {
       const addProcedureSpy = spy(target, 'addProcedure');
       tieredStoMock.mock('buyWithUSDRateLimited', Promise.resolve('BuyWithUSDRateLimited'));
 
-      securityTokenMock.mock('balanceOf', Promise.resolve(new BigNumber(10)));
-
       // Real call
       await target.prepareTransactions();
 
@@ -194,8 +192,6 @@ describe('InvestInTieredSto', () => {
       const addProcedureSpy = spy(target, 'addProcedure');
       tieredStoMock.mock('buyWithUSDRateLimited', Promise.resolve('BuyWithUSDRateLimited'));
 
-      securityTokenMock.mock('balanceOf', Promise.resolve(new BigNumber(10)));
-
       // Real call
       await target.prepareTransactions();