-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Add Polymer Starter Kit tutorial documents #1351
Conversation
gulp serve now uses `http://localhost:5000` for psk.
Change local hosthost:3000 to localhost:5000
We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm. |
Hmm. I confirm that I authored these requests. |
Ignore the CLA checker. It hits false positives for Googlers when commits are authored using their personal email addresses :) |
Is this ready to merge? |
I'll defer to @arthurevans on whether it can land yet or not. I was under the impression we were holding out on a larger IA refresh before doing so. |
…Polymer Starter Kit'.
OK @arthurevans I addressed each of your items and this is ready for next round of review. You can see my responses to each of your inline comments above. |
|
||
* A [Material Design][md] layout | ||
* Routing with Page.js | ||
* Web component unit testing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we go with "Unit testing with [web-component-tester](link to repo)." And periods for all.
Looking good 😎 A couple of minor comments. |
Add Polymer Starter Kit tutorial documents
Awesome! 🎉 🎆 🎉 |
Polymer team is planning to review these in late September. Just adding a PR so we don't forget about it :)
Anyone who stumbles upon this is welcome to offer feedback