Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

Add Polymer Starter Kit tutorial documents #1351

Merged
merged 53 commits into from
Nov 13, 2015

Conversation

kaycebasques
Copy link
Contributor

Polymer team is planning to review these in late September. Just adding a PR so we don't forget about it :)

Anyone who stumbles upon this is welcome to offer feedback

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.

@kaycebasques
Copy link
Contributor Author

Hmm. I confirm that I authored these requests.

@addyosmani
Copy link
Member

Ignore the CLA checker. It hits false positives for Googlers when commits are authored using their personal email addresses :)

@ebidel
Copy link
Contributor

ebidel commented Oct 19, 2015

Is this ready to merge?

@ebidel ebidel added cla: yes and removed cla: no labels Oct 19, 2015
@addyosmani
Copy link
Member

I'll defer to @arthurevans on whether it can land yet or not. I was under the impression we were holding out on a larger IA refresh before doing so.

@addyosmani addyosmani self-assigned this Oct 23, 2015
@kaycebasques
Copy link
Contributor Author

OK @arthurevans I addressed each of your items and this is ready for next round of review. You can see my responses to each of your inline comments above.


* A [Material Design][md] layout
* Routing with Page.js
* Web component unit testing

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we go with "Unit testing with [web-component-tester](link to repo)." And periods for all.

@arthurevans
Copy link

Looking good 😎 A couple of minor comments.

@kaycebasques kaycebasques added this to the Q4S3 milestone Nov 13, 2015
kaycebasques added a commit that referenced this pull request Nov 13, 2015
Add Polymer Starter Kit tutorial documents
@kaycebasques kaycebasques merged commit 6f27545 into master Nov 13, 2015
@arthurevans
Copy link

Awesome! 🎉 🎆 🎉

@kaycebasques
Copy link
Contributor Author

dancing-penn-state-hockey-fan-dancing-sports-fan-gifs

@arthurevans arthurevans deleted the kaycebasques-psk-tutorial branch November 16, 2015 23:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants