Add friendly error message for missing dotfiles #580
Conversation
|
We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm. |
|
LGTM! |
| }, []); | ||
|
|
||
| if (missingFiles.length) { | ||
| throw new Error('Missing Required Files\n' + missingFiles.join('\n')); |
There was a problem hiding this comment.
In gulp land, is the preference to throw or return the error here?
There was a problem hiding this comment.
hmm my through was to throw inside of the task and if we want to pass an error out we can do that in the gulpfile... let me tweak it as see if passing an error explicitly looks nicer
There was a problem hiding this comment.
good call, it is better
samccone
force-pushed
the
sjs/file-checks
branch
from
208c5c9
to
aa652cb
Compare
Add friendly error message for missing dotfiles
|
best day ever thanks a ton @ohanhi 🌵 |
|
This is great! 🎈🎉🎊 Thank you, @samccone! |
via #555
fixes #544
R @robdodson